From 71d98443c3a0822810c9186b601d627422fe1c83 Mon Sep 17 00:00:00 2001 From: Diamond Rivero Date: Tue, 8 Oct 2024 16:47:17 +0800 Subject: [PATCH] Fix Errcheck issues in server/channels/api4/export.go (#28407) Co-authored-by: Ben Schumacher --- server/.golangci.yml | 1 - server/channels/api4/export.go | 9 +++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index c2cf4358b9..960fae33f6 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -74,7 +74,6 @@ issues: channels/api4/config_local.go|\ channels/api4/config_test.go|\ channels/api4/data_retention.go|\ - channels/api4/export.go|\ channels/api4/export_test.go|\ channels/api4/file_test.go|\ channels/api4/import_test.go|\ diff --git a/server/channels/api4/export.go b/server/channels/api4/export.go index 6cfe593922..be25f153ac 100644 --- a/server/channels/api4/export.go +++ b/server/channels/api4/export.go @@ -10,6 +10,7 @@ import ( "time" "github.com/mattermost/mattermost/server/public/model" + "github.com/mattermost/mattermost/server/public/shared/mlog" "github.com/mattermost/mattermost/server/v8/channels/audit" ) @@ -38,7 +39,9 @@ func listExports(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(data) + if _, err := w.Write(data); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func deleteExport(c *Context, w http.ResponseWriter, r *http.Request) { @@ -109,6 +112,8 @@ func generatePresignURLExport(c *Context, w http.ResponseWriter, r *http.Request return } - w.Write(data) auditRec.Success() + if _, err := w.Write(data); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } }