[MM-55296] Added warning in Workspace dashboard if Mattermost is running as root (#27999)

Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Этот коммит содержится в:
goooov
2024-09-18 15:21:50 +05:30
коммит произвёл GitHub
родитель c12e6d9e9c
Коммит 70cb1934e9
5 изменённых файлов: 78 добавлений и 16 удалений

Просмотреть файл

@@ -61,34 +61,46 @@ func TestGetPing(t *testing.T) {
th.TestForAllClients(t, func(t *testing.T, client *model.Client4) {
th.App.ReloadConfig()
resp, err := client.DoAPIGet(context.Background(), "/system/ping", "")
respMap, resp, err := client.GetPingWithOptions(context.Background(), model.SystemPingOptions{})
require.NoError(t, err)
require.Equal(t, http.StatusOK, resp.StatusCode)
respBytes, err := io.ReadAll(resp.Body)
require.NoError(t, err)
respString := string(respBytes)
require.NotContains(t, respString, "TestFeatureFlag")
_, ok := respMap["TestFeatureFlag"]
assert.Equal(t, false, ok)
// Run the environment variable override code to test
os.Setenv("MM_FEATUREFLAGS_TESTFEATURE", "testvalueunique")
defer os.Unsetenv("MM_FEATUREFLAGS_TESTFEATURE")
th.App.ReloadConfig()
resp, err = client.DoAPIGet(context.Background(), "/system/ping", "")
respMap, resp, err = client.GetPingWithOptions(context.Background(), model.SystemPingOptions{})
require.NoError(t, err)
require.Equal(t, http.StatusOK, resp.StatusCode)
respBytes, err = io.ReadAll(resp.Body)
require.NoError(t, err)
respString = string(respBytes)
require.Contains(t, respString, "testvalue")
_, ok = respMap["TestFeatureFlag"]
assert.Equal(t, true, ok)
}, "ping feature flag test")
t.Run("ping root_status test", func(t *testing.T) {
respMap, resp, err := th.SystemAdminClient.GetPingWithOptions(context.Background(), model.SystemPingOptions{FullStatus: true})
require.NoError(t, err)
require.Equal(t, http.StatusOK, resp.StatusCode)
_, ok := respMap["root_status"]
assert.Equal(t, true, ok)
})
t.Run("ping root_status test with client user", func(t *testing.T) {
respMap, resp, err := th.Client.GetPingWithOptions(context.Background(), model.SystemPingOptions{FullStatus: true})
require.NoError(t, err)
require.Equal(t, http.StatusOK, resp.StatusCode)
_, ok := respMap["root_status"]
assert.Equal(t, false, ok)
})
th.TestForAllClients(t, func(t *testing.T, client *model.Client4) {
th.App.ReloadConfig()
resp, err := client.DoAPIGet(context.Background(), "/system/ping?device_id=platform:id", "")
require.NoError(t, err)
require.Equal(t, http.StatusOK, resp.StatusCode)
var respMap map[string]string
var respMap map[string]any
err = json.NewDecoder(resp.Body).Decode(&respMap)
require.NoError(t, err)
assert.Equal(t, "unknown", respMap["CanReceiveNotifications"]) // Unrecognized platform