Changed how posts are marked ephemeral

web/react/components/post_info.jsx

@@ -30,7 +30,7 @@ export default class PostInfo extends React.Component {
         var isOwner = UserStore.getCurrentId() === post.user_id;
         var isAdmin = Utils.isAdmin(UserStore.getCurrentUser().roles);
 
-        if (post.state === Constants.POST_FAILED || post.state === Constants.POST_LOADING || post.ephemeral) {
+        if (post.state === Constants.POST_FAILED || post.state === Constants.POST_LOADING || Utils.isPostEphemeral(post)) {
             return '';
         }
 
@@ -171,7 +171,7 @@ export default class PostInfo extends React.Component {
         EventHelpers.emitRemovePost(this.props.post);
     }
     createRemovePostButton(post) {
-        if (!post.ephemeral) {
+        if (!Utils.isPostEphemeral(post)) {
             return null;
         }
 
@@ -198,7 +198,7 @@ export default class PostInfo extends React.Component {
             commentCountText = '';
         }
 
-        if (post.state !== Constants.POST_FAILED && post.state !== Constants.POST_LOADING && !post.ephemeral) {
+        if (post.state !== Constants.POST_FAILED && post.state !== Constants.POST_LOADING && !Utils.isPostEphemeral(post)) {
             comments = (
                 <a
                     href='#'

web/react/stores/post_store.jsx

@@ -342,8 +342,7 @@ class PostStoreClass extends EventEmitter {
             // make sure to copy the post so that component state changes work properly
             postList.posts[post.id] = Object.assign({}, post, {
                 state: Constants.POST_DELETED,
-                filenames: [],
-                ephemeral: true
+                filenames: []
             });
         }
     }

web/react/utils/constants.jsx

@@ -128,8 +128,8 @@ export default {
     POST_LOADING: 'loading',
     POST_FAILED: 'failed',
     POST_DELETED: 'deleted',
-    POST_TYPE_JOIN_LEAVE: 'system_join_leave',
     POST_TYPE_EPHEMERAL: 'system_ephemeral',
+    POST_TYPE_JOIN_LEAVE: 'system_join_leave',
     SYSTEM_MESSAGE_PREFIX: 'system_',
     SYSTEM_MESSAGE_PROFILE_NAME: 'System',
     SYSTEM_MESSAGE_PROFILE_IMAGE: '/static/images/logo_compact.png',

web/react/utils/utils.jsx

@@ -1355,3 +1355,7 @@ export function languages() {
         ]
     );
 }
+
+export function isPostEphemeral(post) {
+    return post.type === Constants.POST_TYPE_EPHEMERAL || post.state === Constants.POST_DELETED;
+}