[ABAC - Table Editor] Improvements on table editor and review feedback (#31125)

* reflect review comments

* update table editor

* adjust test limits

* reflect review comments

* MM-64376

* resolve conflicts

* address review comments

* fix merge conflict error
Этот коммит содержится в:
Ibrahim Serdar Acikgoz
2025-06-01 12:05:57 +02:00
коммит произвёл GitHub
родитель 489ea1fdd6
Коммит 6f26ad5cec
33 изменённых файлов: 1360 добавлений и 635 удалений

Просмотреть файл

@@ -482,7 +482,7 @@ func (s *SqlAccessControlPolicyStore) GetAll(_ request.CTX, opts model.GetAccess
limit := uint64(opts.Limit)
if limit < 1 {
limit = 10
limit = 1
} else if limit > MaxPerPage {
limit = MaxPerPage
}
@@ -576,7 +576,7 @@ func (s *SqlAccessControlPolicyStore) SearchPolicies(rctx request.CTX, opts mode
limit := uint64(opts.Limit)
if limit < 1 {
limit = 10
limit = 1
} else if limit > MaxPerPage {
limit = MaxPerPage
}

Просмотреть файл

@@ -319,14 +319,14 @@ func testAccessControlPolicyStoreGetAll(t *testing.T, rctx request.CTX, ss store
require.NoError(t, err)
require.NotNil(t, resourcePolicy)
t.Run("GetAll", func(t *testing.T) {
policies, _, err := ss.AccessControlPolicy().SearchPolicies(rctx, model.AccessControlPolicySearch{})
policies, _, err := ss.AccessControlPolicy().SearchPolicies(rctx, model.AccessControlPolicySearch{Limit: 10})
require.NoError(t, err)
require.NotNil(t, policies)
require.Len(t, policies, 3)
})
t.Run("GetAll by type", func(t *testing.T) {
policies, _, err := ss.AccessControlPolicy().SearchPolicies(rctx, model.AccessControlPolicySearch{Type: model.AccessControlPolicyTypeParent, IncludeChildren: true})
policies, _, err := ss.AccessControlPolicy().SearchPolicies(rctx, model.AccessControlPolicySearch{Type: model.AccessControlPolicyTypeParent, IncludeChildren: true, Limit: 10})
require.NoError(t, err)
require.NotNil(t, policies)
require.Len(t, policies, 2)