MM-61652: Removed heading related role from channel header (#30277)

e2e-tests/cypress/tests/integration/playbooks/channels/rhs/about_spec.js

@@ -90,7 +90,7 @@ describe('channels > rhs > header', {testIsolation: true}, () => {
             cy.get('#rhsContainer').findByTestId('rendered-run-name').should('be.visible').contains('new run name');
 
             // * make sure the channel name remains unchanged
-            cy.get('#channelHeaderInfo').findByRole('heading').contains(playbookRunName);
+            cy.get('#channelHeaderInfo').contains(playbookRunName);
         });
     });
 

webapp/channels/src/components/channel_header/channel_header_title.tsx

@@ -105,8 +105,6 @@ const ChannelHeaderTitle = ({
                     size='sm'
                 />
                 <strong
-                    role='heading'
-                    aria-level={2}
                     id='channelHeaderTitle'
                     className='heading'
                 >
@@ -148,46 +146,49 @@ const ChannelHeaderTitle = ({
                 <div
                     id='channelHeaderDropdownButton'
                 >
-                    <strong
+                    <button
-                        role='heading'
+                        className={classNames('channel-header__trigger style--none', {active: titleMenuOpen})}
-                        aria-level={2}
+                        aria-label={
-                        id='channelHeaderTitle'
+                            (isDirect && currentUser.id === dmUser?.id) ? personalChannelHeaderAriaLabel.toLowerCase() : othersChannelHeaderAriaLabel.toLowerCase()
-                        className='heading'
+                        }
-                        ref={headerItemRef}
+                        aria-expanded={titleMenuOpen}
+                        aria-controls='channelHeaderDropdownMenu'
                     >
-                        <button
+                        {showTooltip ? (
-                            id='channel_header.menuAriaLabel'
+                            <WithTooltip
-                            className={classNames('channel-header__trigger style--none', {active: titleMenuOpen})}
+                                title={channelTitle as string}
-                            aria-label={
+                            >
-                                (isDirect && currentUser.id === dmUser?.id) ? personalChannelHeaderAriaLabel.toLowerCase() : othersChannelHeaderAriaLabel.toLowerCase()
+                                <strong
-                            }
+                                    id='channelHeaderTitle'
-                            aria-expanded={titleMenuOpen}
+                                    className='heading'
-                            aria-controls='channelHeaderDropdownMenu'
+                                    ref={headerItemRef}
-                        >
-                            {showTooltip ? (
-                                <WithTooltip
-                                    title={channelTitle as string}
                                 >
                                     <span>
                                         {archivedIcon}
                                         {channelTitle}
                                         {sharedIcon}
                                     </span>
-                                </WithTooltip>
+                                </strong>
-                            ) : (
+                            </WithTooltip>
+                        ) : (
+                            <strong
+                                id='channelHeaderTitle'
+                                className='heading'
+                                ref={headerItemRef}
+                            >
                                 <span>
                                     {archivedIcon}
                                     {channelTitle}
                                     {sharedIcon}
                                 </span>
-                            )}
+                            </strong>
-                            <span
+                        )}
-                                id='channelHeaderDropdownIcon'
+                        <span
-                                className='icon icon-chevron-down header-dropdown-chevron-icon'
+                            id='channelHeaderDropdownIcon'
-                                aria-hidden='true'
+                            className='icon icon-chevron-down header-dropdown-chevron-icon'
-                            />
+                            aria-hidden='true'
-                        </button>
+                        />
-                    </strong>
+                    </button>
                 </div>
                 <ChannelHeaderDropdown
                     ariaLabel={

webapp/channels/src/sass/layout/_headers.scss

@@ -209,7 +209,6 @@
     .heading {
         overflow: hidden;
         align-self: center;
-        padding: 4px;
         margin: 0 0 0 2px;
         color: var(--center-channel-color);
         font-family: Metropolis, sans-serif;