MM-61652: Removed heading related role from channel header (#30277)

e2e-tests/cypress/tests/integration/playbooks/channels/rhs/about_spec.js

@@ -90,7 +90,7 @@ describe('channels > rhs > header', {testIsolation: true}, () => {
             cy.get('#rhsContainer').findByTestId('rendered-run-name').should('be.visible').contains('new run name');
 
             // * make sure the channel name remains unchanged
-            cy.get('#channelHeaderInfo').findByRole('heading').contains(playbookRunName);
+            cy.get('#channelHeaderInfo').contains(playbookRunName);
         });
     });
 

webapp/channels/src/components/channel_header/channel_header_title.tsx

@@ -105,8 +105,6 @@ const ChannelHeaderTitle = ({
                     size='sm'
                 />
                 <strong
-                    role='heading'
-                    aria-level={2}
                     id='channelHeaderTitle'
                     className='heading'
                 >
@@ -147,16 +145,8 @@ const ChannelHeaderTitle = ({
             <MenuWrapper onToggle={setTitleMenuOpen}>
                 <div
                     id='channelHeaderDropdownButton'
-                >
-                    <strong
-                        role='heading'
-                        aria-level={2}
-                        id='channelHeaderTitle'
-                        className='heading'
-                        ref={headerItemRef}
                 >
                     <button
-                            id='channel_header.menuAriaLabel'
                         className={classNames('channel-header__trigger style--none', {active: titleMenuOpen})}
                         aria-label={
                             (isDirect && currentUser.id === dmUser?.id) ? personalChannelHeaderAriaLabel.toLowerCase() : othersChannelHeaderAriaLabel.toLowerCase()
@@ -167,19 +157,31 @@ const ChannelHeaderTitle = ({
                         {showTooltip ? (
                             <WithTooltip
                                 title={channelTitle as string}
+                            >
+                                <strong
+                                    id='channelHeaderTitle'
+                                    className='heading'
+                                    ref={headerItemRef}
                                 >
                                     <span>
                                         {archivedIcon}
                                         {channelTitle}
                                         {sharedIcon}
                                     </span>
+                                </strong>
                             </WithTooltip>
                         ) : (
+                            <strong
+                                id='channelHeaderTitle'
+                                className='heading'
+                                ref={headerItemRef}
+                            >
                                 <span>
                                     {archivedIcon}
                                     {channelTitle}
                                     {sharedIcon}
                                 </span>
+                            </strong>
                         )}
                         <span
                             id='channelHeaderDropdownIcon'
@@ -187,7 +189,6 @@ const ChannelHeaderTitle = ({
                             aria-hidden='true'
                         />
                     </button>
-                    </strong>
                 </div>
                 <ChannelHeaderDropdown
                     ariaLabel={

webapp/channels/src/sass/layout/_headers.scss

@@ -209,7 +209,6 @@
     .heading {
         overflow: hidden;
         align-self: center;
-        padding: 4px;
         margin: 0 0 0 2px;
         color: var(--center-channel-color);
         font-family: Metropolis, sans-serif;