[GH-25492] Add the request context to all public methods in server/channels/app/admin.go (#25498)
Этот коммит содержится в:
@@ -37,13 +37,13 @@ func TestGetLatestVersion(t *testing.T) {
|
||||
defer ts.Close()
|
||||
|
||||
t.Run("get latest mm version happy path", func(t *testing.T) {
|
||||
_, err := th.App.GetLatestVersion(ts.URL)
|
||||
_, err := th.App.GetLatestVersion(th.Context, ts.URL)
|
||||
require.Nil(t, err)
|
||||
})
|
||||
|
||||
t.Run("get latest mm version from cache", func(t *testing.T) {
|
||||
th.App.ClearLatestVersionCache()
|
||||
originalResult, err := th.App.GetLatestVersion(ts.URL)
|
||||
th.App.ClearLatestVersionCache(th.Context)
|
||||
originalResult, err := th.App.GetLatestVersion(th.Context, ts.URL)
|
||||
require.Nil(t, err)
|
||||
|
||||
// Call same function but mock the GET request to return a different result.
|
||||
@@ -66,14 +66,14 @@ func TestGetLatestVersion(t *testing.T) {
|
||||
}))
|
||||
defer ts.Close()
|
||||
|
||||
cachedResult, err := th.App.GetLatestVersion(updatedServer.URL)
|
||||
cachedResult, err := th.App.GetLatestVersion(th.Context, updatedServer.URL)
|
||||
require.Nil(t, err)
|
||||
|
||||
require.Equal(t, originalResult.TagName, cachedResult.TagName, "did not get cached result")
|
||||
})
|
||||
|
||||
t.Run("get latest mm version error from external", func(t *testing.T) {
|
||||
th.App.ClearLatestVersionCache()
|
||||
th.App.ClearLatestVersionCache(th.Context)
|
||||
errorServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.WriteHeader(http.StatusInternalServerError)
|
||||
w.Write([]byte(`
|
||||
@@ -84,7 +84,7 @@ func TestGetLatestVersion(t *testing.T) {
|
||||
}))
|
||||
defer ts.Close()
|
||||
|
||||
_, appErr := th.App.GetLatestVersion(errorServer.URL)
|
||||
_, appErr := th.App.GetLatestVersion(th.Context, errorServer.URL)
|
||||
require.NotNil(t, appErr)
|
||||
})
|
||||
}
|
||||
|
||||
Ссылка в новой задаче
Block a user