PLT-2990 Clicking on a desktop notification from another team opens the team (#3253)

Этот коммит содержится в:
enahum
2016-06-06 10:46:09 -03:00
коммит произвёл Harrison Healey
родитель 6ab893dcba
Коммит 6cee1f87f2
4 изменённых файлов: 19 добавлений и 6 удалений

Просмотреть файл

@@ -32,6 +32,7 @@ class NotificationStoreClass extends EventEmitter {
if (msgProps.mentions) {
mentions = JSON.parse(msgProps.mentions);
}
const teamId = msgProps.team_id;
const channel = ChannelStore.get(post.channel_id);
const user = UserStore.getCurrentUser();
@@ -67,14 +68,14 @@ class NotificationStoreClass extends EventEmitter {
if (notifyText.length === 0) {
if (msgProps.image) {
Utils.notifyMe(title, username + Utils.localizeMessage('channel_loader.uploadedImage', ' uploaded an image'), channel);
Utils.notifyMe(title, username + Utils.localizeMessage('channel_loader.uploadedImage', ' uploaded an image'), channel, teamId);
} else if (msgProps.otherFile) {
Utils.notifyMe(title, username + Utils.localizeMessage('channel_loader.uploadedFile', ' uploaded a file'), channel);
Utils.notifyMe(title, username + Utils.localizeMessage('channel_loader.uploadedFile', ' uploaded a file'), channel, teamId);
} else {
Utils.notifyMe(title, username + Utils.localizeMessage('channel_loader.something', ' did something new'), channel);
Utils.notifyMe(title, username + Utils.localizeMessage('channel_loader.something', ' did something new'), channel, teamId);
}
} else {
Utils.notifyMe(title, username + Utils.localizeMessage('channel_loader.wrote', ' wrote: ') + notifyText, channel);
Utils.notifyMe(title, username + Utils.localizeMessage('channel_loader.wrote', ' wrote: ') + notifyText, channel, teamId);
}
if (!user.notify_props || user.notify_props.desktop_sound === 'true') {
Utils.ding();

Просмотреть файл

@@ -109,6 +109,15 @@ class TeamStoreClass extends EventEmitter {
return '';
}
getTeamUrl(id) {
const team = this.get(id);
if (team) {
return getWindowLocationOrigin() + '/' + team.name;
}
return null;
}
saveTeam(team) {
this.teams[team.id] = team;
}

Просмотреть файл

@@ -119,7 +119,7 @@ export function getCookie(name) {
var requestedNotificationPermission = false;
export function notifyMe(title, body, channel) {
export function notifyMe(title, body, channel, teamId) {
if (!('Notification' in window)) {
return;
}
@@ -134,7 +134,9 @@ export function notifyMe(title, body, channel) {
notification.onclick = () => {
window.focus();
if (channel) {
browserHistory.push(getTeamURLNoOriginFromAddressBar() + '/channels/' + channel.name);
browserHistory.push(TeamStore.getTeamUrl(teamId) + '/channels/' + channel.name);
} else if (teamId) {
browserHistory.push(TeamStore.getTeamUrl(teamId) + '/channels/town-square');
} else {
browserHistory.push(TeamStore.getCurrentTeamUrl() + '/channels/town-square');
}