update go to 1.12 (#10382)

* update go to 1.12

* update per feedback

* fix test

* revert test changes

* remove zap.AddCallerSkip(1)

mlog/global_test.go

@@ -136,7 +136,7 @@ func TestLoggingAfterInitialized(t *testing.T) {
 
 					actual = strings.Join(actualRows, "\n")
 				}
-				require.Equal(t, testCase.ExpectedLogs, strings.Split(actual, "\n"))
+				require.ElementsMatch(t, testCase.ExpectedLogs, strings.Split(actual, "\n"))
 			}
 		})
 	}

mlog/log.go

@@ -102,7 +102,6 @@ func NewLogger(config *LoggerConfiguration) *Logger {
 	combinedCore := zapcore.NewTee(cores...)
 
 	logger.zap = zap.New(combinedCore,
-		zap.AddCallerSkip(1),
 		zap.AddCaller(),
 	)
 

mlog/testing.go

@@ -35,7 +35,6 @@ func NewTestingLogger(tb testing.TB) *Logger {
 	logWriterCore := zapcore.NewCore(makeEncoder(true), logWriterSync, testingLogger.consoleLevel)
 
 	testingLogger.zap = zap.New(logWriterCore,
-		zap.AddCallerSkip(1),
 		zap.AddCaller(),
 	)
 	return testingLogger