From 66a3eba2cf481d0edd7d23d42b8abcc4d7f81b72 Mon Sep 17 00:00:00 2001 From: Pavel Mokeev <75482510+pmokeev@users.noreply.github.com> Date: Fri, 31 May 2024 20:24:00 +0300 Subject: [PATCH] Add ctx usage in Client4 methods (#26973) * Add ctx usage in Client4 methods * Add ctx usage to more Client4 methods * fix missing ctx usage --------- Co-authored-by: Mattermost Build --- server/public/model/client4.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/server/public/model/client4.go b/server/public/model/client4.go index fe146b9bfe..fc229a74c7 100644 --- a/server/public/model/client4.go +++ b/server/public/model/client4.go @@ -698,7 +698,7 @@ func (c *Client4) DoUploadFile(ctx context.Context, url string, data []byte, con } func (c *Client4) doUploadFile(ctx context.Context, url string, body io.Reader, contentType string, contentLength int64) (*FileUploadResponse, *Response, error) { - rq, err := http.NewRequest("POST", c.APIURL+url, body) + rq, err := http.NewRequestWithContext(ctx, "POST", c.APIURL+url, body) if err != nil { return nil, nil, err } @@ -757,7 +757,7 @@ func (c *Client4) DoEmojiUploadFile(ctx context.Context, url string, data []byte } func (c *Client4) DoUploadImportTeam(ctx context.Context, url string, data []byte, contentType string) (map[string]string, *Response, error) { - rq, err := http.NewRequest("POST", c.APIURL+url, bytes.NewReader(data)) + rq, err := http.NewRequestWithContext(ctx, "POST", c.APIURL+url, bytes.NewReader(data)) if err != nil { return nil, nil, err } @@ -1817,7 +1817,7 @@ func (c *Client4) SetProfileImage(ctx context.Context, userId string, data []byt return nil, NewAppError("SetProfileImage", "model.client.set_profile_user.writer.app_error", nil, "", http.StatusBadRequest).Wrap(err) } - rq, err := http.NewRequest("POST", c.APIURL+c.userRoute(userId)+"/image", bytes.NewReader(body.Bytes())) + rq, err := http.NewRequestWithContext(ctx, "POST", c.APIURL+c.userRoute(userId)+"/image", bytes.NewReader(body.Bytes())) if err != nil { return nil, err } @@ -2889,7 +2889,7 @@ func (c *Client4) SetTeamIcon(ctx context.Context, teamId string, data []byte) ( return nil, NewAppError("SetTeamIcon", "model.client.set_team_icon.writer.app_error", nil, "", http.StatusBadRequest).Wrap(err) } - rq, err := http.NewRequest("POST", c.APIURL+c.teamRoute(teamId)+"/image", bytes.NewReader(body.Bytes())) + rq, err := http.NewRequestWithContext(ctx, "POST", c.APIURL+c.teamRoute(teamId)+"/image", bytes.NewReader(body.Bytes())) if err != nil { return nil, err } @@ -4850,7 +4850,7 @@ func (c *Client4) UploadLicenseFile(ctx context.Context, data []byte) (*Response return nil, NewAppError("UploadLicenseFile", "model.client.set_profile_user.writer.app_error", nil, "", http.StatusBadRequest).Wrap(err) } - rq, err := http.NewRequest("POST", c.APIURL+c.licenseRoute(), bytes.NewReader(body.Bytes())) + rq, err := http.NewRequestWithContext(ctx, "POST", c.APIURL+c.licenseRoute(), bytes.NewReader(body.Bytes())) if err != nil { return nil, err } @@ -5422,7 +5422,7 @@ func (c *Client4) GetComplianceReport(ctx context.Context, reportId string) (*Co // DownloadComplianceReport returns a full compliance report as a file. func (c *Client4) DownloadComplianceReport(ctx context.Context, reportId string) ([]byte, *Response, error) { - rq, err := http.NewRequest("GET", c.APIURL+c.complianceReportDownloadRoute(reportId), nil) + rq, err := http.NewRequestWithContext(ctx, "GET", c.APIURL+c.complianceReportDownloadRoute(reportId), nil) if err != nil { return nil, nil, err } @@ -5826,7 +5826,7 @@ func (c *Client4) UploadBrandImage(ctx context.Context, data []byte) (*Response, return nil, NewAppError("UploadBrandImage", "model.client.set_profile_user.writer.app_error", nil, "", http.StatusBadRequest).Wrap(err) } - rq, err := http.NewRequest("POST", c.APIURL+c.brandRoute()+"/image", bytes.NewReader(body.Bytes())) + rq, err := http.NewRequestWithContext(ctx, "POST", c.APIURL+c.brandRoute()+"/image", bytes.NewReader(body.Bytes())) if err != nil { return nil, err } @@ -6023,7 +6023,7 @@ func (c *Client4) DeauthorizeOAuthApp(ctx context.Context, appId string) (*Respo // GetOAuthAccessToken is a test helper function for the OAuth access token endpoint. func (c *Client4) GetOAuthAccessToken(ctx context.Context, data url.Values) (*AccessResponse, *Response, error) { url := c.URL + "/oauth/access_token" - rq, err := http.NewRequest(http.MethodPost, url, strings.NewReader(data.Encode())) + rq, err := http.NewRequestWithContext(ctx, http.MethodPost, url, strings.NewReader(data.Encode())) if err != nil { return nil, nil, err } @@ -7305,7 +7305,7 @@ func (c *Client4) uploadPlugin(ctx context.Context, file io.Reader, force bool) return nil, nil, err } - rq, err := http.NewRequest("POST", c.APIURL+c.pluginsRoute(), body) + rq, err := http.NewRequestWithContext(ctx, "POST", c.APIURL+c.pluginsRoute(), body) if err != nil { return nil, nil, err }