unparam lint (#16927)

* fix "always receives ..." lint err

* add unparam lint check

* fix failed test

* rm details param

* ignore unparam lint

* magic string replaced with model.NewRandomString

* rm unused enableComplianceFeatures param

* generate random message inside createPost

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

shared/mail/mail.go

@@ -249,7 +249,7 @@ func SendMailWithEmbeddedFilesUsingConfig(to, subject, htmlBody string, embedded
 		embeddedFiles: embeddedFiles,
 	}
 
-	return sendMailUsingConfigAdvanced(mail, config, enableComplianceFeatures)
+	return sendMailUsingConfigAdvanced(mail, config)
 }
 
 func SendMailUsingConfig(to, subject, htmlBody string, config *SMTPConfig, enableComplianceFeatures bool, ccMail string) error {
@@ -257,7 +257,7 @@ func SendMailUsingConfig(to, subject, htmlBody string, config *SMTPConfig, enabl
 }
 
 // allows for sending an email with differing MIME/SMTP recipients
-func sendMailUsingConfigAdvanced(mail mailData, config *SMTPConfig, enableComplianceFeatures bool) error {
+func sendMailUsingConfigAdvanced(mail mailData, config *SMTPConfig) error {
 	if config.Server == "" {
 		return nil
 	}

shared/mail/mail_test.go

@@ -225,7 +225,7 @@ func TestSendMailUsingConfigAdvanced(t *testing.T) {
 		mimeHeaders:   headers,
 	}
 
-	err = sendMailUsingConfigAdvanced(mail, cfg, true)
+	err = sendMailUsingConfigAdvanced(mail, cfg)
 	require.NoError(t, err, "Should connect to the STMP Server: %v", err)
 
 	//Check if the email was send to the right email address