15249 sync.pool (#16103)

* use sync.pool for session

* added back to sync pool

* reverted change

* added a new line

* added back session object

* added back session object

* added back session object

* revert

* refactored into function

* added the session object back into the pool

* work in progress

* work in progress

* work in progress

* code review comments

Co-authored-by: Arjuna Marambe <arjunam@buildxact.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

services/cache/lru.go

@@ -210,11 +210,6 @@ func (l *LRU) get(key string, value interface{}) error {
 		_, err := u.UnmarshalMsg(val)
 		*v = &u
 		return err
-	case **model.Session:
-		var s model.Session
-		_, err := s.UnmarshalMsg(val)
-		*v = &s
-		return err
 	case *map[string]*model.User:
 		var u model.UserMap
 		_, err := u.UnmarshalMsg(val)

services/cache/lru_test.go

@@ -227,9 +227,9 @@ func TestLRUMarshalUnMarshal(t *testing.T) {
 
 	err = l.Set("session", session)
 	require.Nil(t, err)
+	var s = &model.Session{}
+	err = l.Get("session", s)
 
-	var s *model.Session
-	err = l.Get("session", &s)
 	require.Nil(t, err)
 	require.Equal(t, session, s)