Changed require.Nil to require.NoError when error type is used (#16900)

services/upgrader/upgrader_linux_test.go

@@ -76,12 +76,12 @@ func TestGetCurrentVersionTgzUrl(t *testing.T) {
 func TestExtractBinary(t *testing.T) {
 	t.Run("extract from empty file", func(t *testing.T) {
 		tmpMockTarGz, err := ioutil.TempFile("", "mock_tgz")
-		require.Nil(t, err)
+		require.NoError(t, err)
 		defer os.Remove(tmpMockTarGz.Name())
 		tmpMockTarGz.Close()
 
 		tmpMockExecutable, err := ioutil.TempFile("", "mock_exe")
-		require.Nil(t, err)
+		require.NoError(t, err)
 		defer os.Remove(tmpMockExecutable.Name())
 		tmpMockExecutable.Close()
 
@@ -90,7 +90,7 @@ func TestExtractBinary(t *testing.T) {
 
 	t.Run("extract from empty tar.gz file", func(t *testing.T) {
 		tmpMockTarGz, err := ioutil.TempFile("", "mock_tgz")
-		require.Nil(t, err)
+		require.NoError(t, err)
 		defer os.Remove(tmpMockTarGz.Name())
 		gz := gzip.NewWriter(tmpMockTarGz)
 		tw := tar.NewWriter(gz)
@@ -99,7 +99,7 @@ func TestExtractBinary(t *testing.T) {
 		tmpMockTarGz.Close()
 
 		tmpMockExecutable, err := ioutil.TempFile("", "mock_exe")
-		require.Nil(t, err)
+		require.NoError(t, err)
 		defer os.Remove(tmpMockExecutable.Name())
 		tmpMockExecutable.Close()
 
@@ -108,7 +108,7 @@ func TestExtractBinary(t *testing.T) {
 
 	t.Run("extract from tar.gz without mattermost/bin/mattermost file", func(t *testing.T) {
 		tmpMockTarGz, err := ioutil.TempFile("", "mock_tgz")
-		require.Nil(t, err)
+		require.NoError(t, err)
 		defer os.Remove(tmpMockTarGz.Name())
 		gz := gzip.NewWriter(tmpMockTarGz)
 		tw := tar.NewWriter(gz)
@@ -124,7 +124,7 @@ func TestExtractBinary(t *testing.T) {
 		tmpMockTarGz.Close()
 
 		tmpMockExecutable, err := ioutil.TempFile("", "mock_exe")
-		require.Nil(t, err)
+		require.NoError(t, err)
 		defer os.Remove(tmpMockExecutable.Name())
 		tmpMockExecutable.Close()
 
@@ -133,7 +133,7 @@ func TestExtractBinary(t *testing.T) {
 
 	t.Run("extract from tar.gz with mattermost/bin/mattermost file", func(t *testing.T) {
 		tmpMockTarGz, err := ioutil.TempFile("", "mock_tgz")
-		require.Nil(t, err)
+		require.NoError(t, err)
 		defer os.Remove(tmpMockTarGz.Name())
 		gz := gzip.NewWriter(tmpMockTarGz)
 		tw := tar.NewWriter(gz)
@@ -149,7 +149,7 @@ func TestExtractBinary(t *testing.T) {
 		tmpMockTarGz.Close()
 
 		tmpMockExecutable, err := ioutil.TempFile("", "mock_exe")
-		require.Nil(t, err)
+		require.NoError(t, err)
 		defer os.Remove(tmpMockExecutable.Name())
 		tmpMockExecutable.Close()