Changed require.Nil to require.NoError when error type is used (#16900)

services/docextractor/docextractor_test.go

@@ -110,7 +110,7 @@ func TestExtract(t *testing.T) {
 	for _, tc := range testCases {
 		t.Run(tc.Name, func(t *testing.T) {
 			data, err := testutils.ReadTestFile(tc.TestFileName)
-			require.Nil(t, err)
+			require.NoError(t, err)
 			text, err := Extract(tc.TestFileName, bytes.NewReader(data), tc.Settings)
 			if tc.ExpectError {
 				require.Error(t, err)
@@ -128,7 +128,7 @@ func TestExtract(t *testing.T) {
 
 	t.Run("Unsupported binary file", func(t *testing.T) {
 		data, err := testutils.ReadTestFile("testjpg.jpg")
-		require.Nil(t, err)
+		require.NoError(t, err)
 		text, err := Extract("testjpg.jpg", bytes.NewReader(data), ExtractSettings{})
 		require.NoError(t, err)
 		require.Equal(t, "", text)
@@ -136,7 +136,7 @@ func TestExtract(t *testing.T) {
 
 	t.Run("Wrong extension", func(t *testing.T) {
 		data, err := testutils.ReadTestFile("sample-doc.pdf")
-		require.Nil(t, err)
+		require.NoError(t, err)
 		text, err := Extract("sample-doc.docx", bytes.NewReader(data), ExtractSettings{})
 		require.NoError(t, err)
 		require.Equal(t, "", text)
@@ -166,7 +166,7 @@ func (te *failingExtractor) Extract(filename string, r io.Reader) (string, error
 func TestExtractWithExtraExtractors(t *testing.T) {
 	t.Run("overrite existing extractor", func(t *testing.T) {
 		data, err := testutils.ReadTestFile("sample-doc.pdf")
-		require.Nil(t, err)
+		require.NoError(t, err)
 
 		text, err := ExtractWithExtraExtractors("sample-doc.pdf", bytes.NewReader(data), ExtractSettings{}, []Extractor{&customTestPdfExtractor{}})
 		require.NoError(t, err)
@@ -175,7 +175,7 @@ func TestExtractWithExtraExtractors(t *testing.T) {
 
 	t.Run("failing extractor", func(t *testing.T) {
 		data, err := testutils.ReadTestFile("sample-doc.pdf")
-		require.Nil(t, err)
+		require.NoError(t, err)
 
 		text, err := ExtractWithExtraExtractors("sample-doc.pdf", bytes.NewReader(data), ExtractSettings{}, []Extractor{&failingExtractor{}})
 		require.NoError(t, err)