From 5a3bc43668353e41949d2d48c8956eaa9d061860 Mon Sep 17 00:00:00 2001 From: George Goldberg Date: Tue, 28 Feb 2017 21:28:37 +0000 Subject: [PATCH] PLT-5188: Reinstate delete option on system messages. (#5113) * PLT-5188: Reinstate delete option on system messages. * Fix styling. * Fix empty hover box. --- .../post_view/components/post_info.jsx | 68 ++++++++++--------- webapp/sass/layout/_post.scss | 11 +++ 2 files changed, 48 insertions(+), 31 deletions(-) diff --git a/webapp/components/post_view/components/post_info.jsx b/webapp/components/post_view/components/post_info.jsx index e368e65f4e..331fdeb00f 100644 --- a/webapp/components/post_view/components/post_info.jsx +++ b/webapp/components/post_view/components/post_info.jsx @@ -53,10 +53,8 @@ export default class PostInfo extends React.Component { } createDropdown() { - var post = this.props.post; - - this.canDelete = PostUtils.canDeletePost(post); - this.canEdit = PostUtils.canEditPost(post, this.editDisableAction); + const post = this.props.post; + const isSystemMessage = PostUtils.isSystemMessage(post); if (post.state === Constants.POST_FAILED || post.state === Constants.POST_LOADING) { return ''; @@ -131,22 +129,24 @@ export default class PostInfo extends React.Component { } } - dropdownContents.push( -
  • - - - -
  • - ); + + + + + ); + } if (this.canDelete) { dropdownContents.push( @@ -267,6 +267,9 @@ export default class PostInfo extends React.Component { var commentCountText = this.props.commentCount; const flagIcon = Constants.FLAG_ICON_SVG; + this.canDelete = PostUtils.canDeletePost(post); + this.canEdit = PostUtils.canEditPost(post, this.editDisableAction); + if (this.props.commentCount >= 1) { showCommentClass = ' icon--show'; } else { @@ -296,18 +299,21 @@ export default class PostInfo extends React.Component { {this.createRemovePostButton()} ); - } else if (!PostUtils.isSystemMessage(post)) { - options = ( -
  • -
    - {this.createDropdown()} -
    - {comments} -
  • - ); + } else { + const dropdown = this.createDropdown(); + if (dropdown) { + options = ( +
  • +
    + {dropdown} +
    + {comments} +
  • + ); + } } let flag; diff --git a/webapp/sass/layout/_post.scss b/webapp/sass/layout/_post.scss index 6f148cd7ea..5157c3080c 100644 --- a/webapp/sass/layout/_post.scss +++ b/webapp/sass/layout/_post.scss @@ -518,6 +518,17 @@ position: relative; word-wrap: break-word; + &.post--system { + .post__header { + .col__reply { + min-width: 0; + } + .dropdown { + margin-right: 0; + } + } + } + &:hover { .dropdown, .comment-icon__container,