Adds default team to the remote cluster entity (#27863)

* Adds default team to the remote cluster entity

A new DefaultTeamId field is added to the RemoteCluster entity and its
endpoints, and used when receiving channel invites to choose in which
team to create a new channel.

This will be later extended with the ability for the system admin to
manually accept invites, choosing which team to create the channel on
each. This use case will be triggered when the DefaultTeamId field is
empty, which now simply chooses the first team it finds in the
database as a fallback.

* Fix migrations list

* Fixes channelinvite test case

* Fix i18n

* Fix migration list

server/public/model/remote_cluster.go

@@ -50,33 +50,35 @@ func (bm *Bitmask) UnsetBit(flag Bitmask) {
 }
 
 type RemoteCluster struct {
-	RemoteId     string  `json:"remote_id"`
-	RemoteTeamId string  `json:"remote_team_id"` // Deprecated: this field is no longer used. It's only kept for backwards compatibility.
-	Name         string  `json:"name"`
-	DisplayName  string  `json:"display_name"`
-	SiteURL      string  `json:"site_url"`
-	CreateAt     int64   `json:"create_at"`
-	LastPingAt   int64   `json:"last_ping_at"`
-	Token        string  `json:"token"`
-	RemoteToken  string  `json:"remote_token"`
-	Topics       string  `json:"topics"`
-	CreatorId    string  `json:"creator_id"`
-	PluginID     string  `json:"plugin_id"` // non-empty when sync message are to be delivered via plugin API
-	Options      Bitmask `json:"options"`   // bit-flag set of options
+	RemoteId      string  `json:"remote_id"`
+	RemoteTeamId  string  `json:"remote_team_id"` // Deprecated: this field is no longer used. It's only kept for backwards compatibility.
+	Name          string  `json:"name"`
+	DisplayName   string  `json:"display_name"`
+	SiteURL       string  `json:"site_url"`
+	DefaultTeamId string  `json:"default_team_id"`
+	CreateAt      int64   `json:"create_at"`
+	LastPingAt    int64   `json:"last_ping_at"`
+	Token         string  `json:"token"`
+	RemoteToken   string  `json:"remote_token"`
+	Topics        string  `json:"topics"`
+	CreatorId     string  `json:"creator_id"`
+	PluginID      string  `json:"plugin_id"` // non-empty when sync message are to be delivered via plugin API
+	Options       Bitmask `json:"options"`   // bit-flag set of options
 }
 
 func (rc *RemoteCluster) Auditable() map[string]interface{} {
 	return map[string]interface{}{
-		"remote_id":      rc.RemoteId,
-		"remote_team_id": rc.RemoteTeamId,
-		"name":           rc.Name,
-		"display_name":   rc.DisplayName,
-		"site_url":       rc.SiteURL,
-		"create_at":      rc.CreateAt,
-		"last_ping_at":   rc.LastPingAt,
-		"creator_id":     rc.CreatorId,
-		"plugin_id":      rc.PluginID,
-		"options":        rc.Options,
+		"remote_id":       rc.RemoteId,
+		"remote_team_id":  rc.RemoteTeamId,
+		"name":            rc.Name,
+		"display_name":    rc.DisplayName,
+		"site_url":        rc.SiteURL,
+		"default_team_id": rc.DefaultTeamId,
+		"create_at":       rc.CreateAt,
+		"last_ping_at":    rc.LastPingAt,
+		"creator_id":      rc.CreatorId,
+		"plugin_id":       rc.PluginID,
+		"options":         rc.Options,
 	}
 }
 
@@ -123,6 +125,11 @@ func (rc *RemoteCluster) IsValid() *AppError {
 	if !IsValidId(rc.CreatorId) {
 		return NewAppError("RemoteCluster.IsValid", "model.cluster.is_valid.id.app_error", nil, "creator_id="+rc.CreatorId, http.StatusBadRequest)
 	}
+
+	if rc.DefaultTeamId != "" && !IsValidId(rc.DefaultTeamId) {
+		return NewAppError("RemoteCluster.IsValid", "model.cluster.is_valid.id.app_error", nil, "default_team_id="+rc.DefaultTeamId, http.StatusBadRequest)
+	}
+
 	return nil
 }
 
@@ -132,12 +139,14 @@ func (rc *RemoteCluster) Sanitize() {
 }
 
 type RemoteClusterPatch struct {
-	DisplayName *string `json:"display_name"`
+	DisplayName   *string `json:"display_name"`
+	DefaultTeamId *string `json:"default_team_id"`
 }
 
 func (rcp *RemoteClusterPatch) Auditable() map[string]interface{} {
 	return map[string]interface{}{
-		"display_name": rcp.DisplayName,
+		"display_name":    rcp.DisplayName,
+		"default_team_id": rcp.DefaultTeamId,
 	}
 }
 
@@ -145,6 +154,10 @@ func (rc *RemoteCluster) Patch(patch *RemoteClusterPatch) {
 	if patch.DisplayName != nil {
 		rc.DisplayName = *patch.DisplayName
 	}
+
+	if patch.DefaultTeamId != nil {
+		rc.DefaultTeamId = *patch.DefaultTeamId
+	}
 }
 
 type RemoteClusterWithPassword struct {

server/public/model/remote_cluster_test.go

@@ -27,6 +27,8 @@ func TestRemoteClusterIsValid(t *testing.T) {
 		{name: "Missing create_at", rc: &RemoteCluster{RemoteId: id, Name: NewId(), SiteURL: "example.com"}, valid: false},
 		{name: "Missing last_ping_at", rc: &RemoteCluster{RemoteId: id, Name: NewId(), SiteURL: "example.com", CreatorId: creator, CreateAt: now}, valid: true},
 		{name: "Missing creator", rc: &RemoteCluster{RemoteId: id, Name: NewId(), SiteURL: "example.com", CreateAt: now, LastPingAt: now}, valid: false},
+		{name: "Bad default_team_id", rc: &RemoteCluster{RemoteId: id, Name: NewId(), SiteURL: "example.com", CreateAt: now, LastPingAt: now, CreatorId: creator, DefaultTeamId: "bad-id"}, valid: false},
+		{name: "Valid default_team_id", rc: &RemoteCluster{RemoteId: id, Name: NewId(), SiteURL: "example.com", CreateAt: now, LastPingAt: now, CreatorId: creator, DefaultTeamId: NewId()}, valid: true},
 		{name: "RemoteCluster valid", rc: &RemoteCluster{RemoteId: id, Name: NewId(), SiteURL: "example.com", CreateAt: now, LastPingAt: now, CreatorId: creator}, valid: true},
 		{name: "Include protocol", rc: &RemoteCluster{RemoteId: id, Name: NewId(), SiteURL: "http://example.com", CreateAt: now, LastPingAt: now, CreatorId: creator}, valid: true},
 		{name: "Include protocol & port", rc: &RemoteCluster{RemoteId: id, Name: NewId(), SiteURL: "http://example.com:8065", CreateAt: now, LastPingAt: now, CreatorId: creator}, valid: true},