MM-15021: Adding new builtin system schema for Guests (#10601)

* MM-15021: Adding new builtin system schema for Guests

* Fixing tests

* Setting properly the permissions

* Adding guests to sampledata

* Restrict more roles updates in the app layer for guests

* Adding comment to explain that permissions migration must go at the end

* Setting the default guest role for custom scheme during migration

* Fixing import and export

* Creating scheme guest roles on migration

* Fixing tests

* Fixing tests

* Fixing tests

app/import_validators_test.go

@@ -29,6 +29,11 @@ func TestImportValidateSchemeImportData(t *testing.T) {
 			DisplayName: ptrStr("display name"),
 			Permissions: &[]string{"invite_user"},
 		},
+		DefaultTeamGuestRole: &RoleImportData{
+			Name:        ptrStr("name"),
+			DisplayName: ptrStr("display name"),
+			Permissions: &[]string{"invite_user"},
+		},
 		DefaultChannelAdminRole: &RoleImportData{
 			Name:        ptrStr("name"),
 			DisplayName: ptrStr("display name"),
@@ -39,6 +44,11 @@ func TestImportValidateSchemeImportData(t *testing.T) {
 			DisplayName: ptrStr("display name"),
 			Permissions: &[]string{"invite_user"},
 		},
+		DefaultChannelGuestRole: &RoleImportData{
+			Name:        ptrStr("name"),
+			DisplayName: ptrStr("display name"),
+			Permissions: &[]string{"invite_user"},
+		},
 	}
 	if err := validateSchemeImportData(&data); err != nil {
 		t.Fatal("Validation failed but should have been valid.", err)
@@ -164,6 +174,18 @@ func TestImportValidateSchemeImportData(t *testing.T) {
 		t.Fatal("Should have failed due to spurious role.")
 	}
 
+	data.DefaultTeamUserRole = &RoleImportData{
+		Name:        ptrStr("name"),
+		DisplayName: ptrStr("display name"),
+		Permissions: &[]string{"invite_user"},
+	}
+	data.DefaultTeamGuestRole = nil
+	if err := validateSchemeImportData(&data); err == nil {
+		t.Fatal("Should have failed due to spurious role.")
+	}
+
+	data.DefaultTeamGuestRole = nil
+	data.DefaultTeamUserRole = nil
 	data.DefaultTeamAdminRole = nil
 	if err := validateSchemeImportData(&data); err != nil {
 		t.Fatal("Should have succeeded.")