From 57711d5251fc394ddc8cedad6d64b587b83e7bc0 Mon Sep 17 00:00:00 2001
From: Saurabh Sharma <saurabh.sharma@brightscout.com>
Date: Tue, 28 Jan 2025 21:54:06 +0530
Subject: [PATCH] MM-61638: Ensure custom buttons provide proper name, role,
 and state information (#29904)

* MM-61638: Add aria-hidden to icon

* MM-61638: Add type button to sidebar header button

* MM-61638: Fix failing lint

* MM-61638: Add aria attributes in button

---------

Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
---
 .../sidebar/sidebar_header/sidebar_header.tsx       | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/webapp/channels/src/components/sidebar/sidebar_header/sidebar_header.tsx b/webapp/channels/src/components/sidebar/sidebar_header/sidebar_header.tsx
index e0dc4ad17f..a8f2b8d5f7 100644
--- a/webapp/channels/src/components/sidebar/sidebar_header/sidebar_header.tsx
+++ b/webapp/channels/src/components/sidebar/sidebar_header/sidebar_header.tsx
@@ -55,9 +55,18 @@ const SidebarHeader = (props: Props) => {
                     title={currentTeam.description ? currentTeam.description : currentTeam.display_name}
                 >
                     <h1 className='sidebarHeader'>
-                        <button className='style--none sidebar-header'>
+                        <button
+                            className='style--none sidebar-header'
+                            type='button'
+                            aria-haspopup='menu'
+                            aria-expanded={menuToggled}
+                            aria-controls='sidebarDropdownMenu'
+                        >
                             <span className='title'>{currentTeam.display_name}</span>
-                            <i className='icon icon-chevron-down'/>
+                            <i
+                                className='icon icon-chevron-down'
+                                aria-hidden={true}
+                            />
                         </button>
                     </h1>
                 </WithTooltip>