diff --git a/api4/bot.go b/api4/bot.go index 569d51b793..62c2bc38cf 100644 --- a/api4/bot.go +++ b/api4/bot.go @@ -187,7 +187,7 @@ func getBots(c *Context, w http.ResponseWriter, r *http.Request) { } if err := json.NewEncoder(w).Encode(bots); err != nil { - mlog.Warn("Error while writing response", mlog.Err(err)) + c.Logger.Warn("Error while writing response", mlog.Err(err)) } } @@ -227,7 +227,7 @@ func updateBotActive(c *Context, w http.ResponseWriter, active bool) { auditRec.AddEventObjectType("bot") if err := json.NewEncoder(w).Encode(bot); err != nil { - mlog.Warn("Error while writing response", mlog.Err(err)) + c.Logger.Warn("Error while writing response", mlog.Err(err)) } } diff --git a/app/app_iface.go b/app/app_iface.go index fbc7c4805e..4f1205abc3 100644 --- a/app/app_iface.go +++ b/app/app_iface.go @@ -84,7 +84,7 @@ type AppIface interface { // ConvertUserToBot converts a user to bot. ConvertUserToBot(user *model.User) (*model.Bot, *model.AppError) // CreateBot creates the given bot and corresponding user. - CreateBot(c *request.Context, bot *model.Bot) (*model.Bot, *model.AppError) + CreateBot(c request.CTX, bot *model.Bot) (*model.Bot, *model.AppError) // CreateChannelScheme creates a new Scheme of scope channel and assigns it to the channel. CreateChannelScheme(c request.CTX, channel *model.Channel) (*model.Scheme, *model.AppError) // CreateDefaultMemberships adds users to teams and channels based on their group memberships and how those groups @@ -132,7 +132,7 @@ type AppIface interface { // any ensureBotOptions hence it is not required for now. // TODO: Once the focalboard migration completed, we should add this logic to the app and // let plugin-api use the same code - EnsureBot(c *request.Context, productID string, bot *model.Bot) (string, error) + EnsureBot(c request.CTX, productID string, bot *model.Bot) (string, error) // Expand announcements in incoming webhooks from Slack. Those announcements // can be found in the text attribute, or in the pretext, text, title and value // attributes of the attachment structure. The Slack attachment structure is @@ -354,7 +354,7 @@ type AppIface interface { // This to be used for places we check the users password when they are already logged in DoubleCheckPassword(user *model.User, password string) *model.AppError // UpdateBotActive marks a bot as active or inactive, along with its corresponding user. - UpdateBotActive(c *request.Context, botUserId string, active bool) (*model.Bot, *model.AppError) + UpdateBotActive(c request.CTX, botUserId string, active bool) (*model.Bot, *model.AppError) // UpdateBotOwner changes a bot's owner to the given value. UpdateBotOwner(botUserId, newOwnerId string) (*model.Bot, *model.AppError) // UpdateChannel updates a given channel by its Id. It also publishes the CHANNEL_UPDATED event. @@ -488,7 +488,7 @@ type AppIface interface { CreateOutgoingWebhook(hook *model.OutgoingWebhook) (*model.OutgoingWebhook, *model.AppError) CreatePasswordRecoveryToken(userID, email string) (*model.Token, *model.AppError) CreatePost(c request.CTX, post *model.Post, channel *model.Channel, triggerWebhooks, setOnline bool) (savedPost *model.Post, err *model.AppError) - CreatePostAsUser(c *request.Context, post *model.Post, currentSessionId string, setOnline bool) (*model.Post, *model.AppError) + CreatePostAsUser(c request.CTX, post *model.Post, currentSessionId string, setOnline bool) (*model.Post, *model.AppError) CreatePostMissingChannel(c request.CTX, post *model.Post, triggerWebhooks bool) (*model.Post, *model.AppError) CreateRetentionPolicy(policy *model.RetentionPolicyWithTeamAndChannelIDs) (*model.RetentionPolicyWithTeamAndChannelCounts, *model.AppError) CreateRole(role *model.Role) (*model.Role, *model.AppError) @@ -1080,7 +1080,7 @@ type AppIface interface { TotalWebsocketConnections() int TriggerWebhook(c request.CTX, payload *model.OutgoingWebhookPayload, hook *model.OutgoingWebhook, post *model.Post, channel *model.Channel) UnregisterPluginCommand(pluginID, teamID, trigger string) - UpdateActive(c *request.Context, user *model.User, active bool) (*model.User, *model.AppError) + UpdateActive(c request.CTX, user *model.User, active bool) (*model.User, *model.AppError) UpdateChannelMemberNotifyProps(c request.CTX, data map[string]string, channelID string, userID string) (*model.ChannelMember, *model.AppError) UpdateChannelMemberRoles(c request.CTX, channelID string, userID string, newRoles string) (*model.ChannelMember, *model.AppError) UpdateChannelMemberSchemeRoles(c request.CTX, channelID string, userID string, isSchemeGuest bool, isSchemeUser bool, isSchemeAdmin bool) (*model.ChannelMember, *model.AppError) diff --git a/app/bot.go b/app/bot.go index 5ec00cb093..d998f7a684 100644 --- a/app/bot.go +++ b/app/bot.go @@ -38,7 +38,7 @@ func (w *botServiceWrapper) EnsureBot(c *request.Context, productID string, bot // any ensureBotOptions hence it is not required for now. // TODO: Once the focalboard migration completed, we should add this logic to the app and // let plugin-api use the same code -func (a *App) EnsureBot(c *request.Context, productID string, bot *model.Bot) (string, error) { +func (a *App) EnsureBot(c request.CTX, productID string, bot *model.Bot) (string, error) { if bot == nil { return "", errors.New("passed a nil bot") } @@ -77,7 +77,7 @@ func (a *App) EnsureBot(c *request.Context, productID string, bot *model.Bot) (s return "", fmt.Errorf("failed to set plugin key: %w", err) } } else { - a.Srv().Log.Error("Product attempted to use an account that already exists. Convert user to a bot "+ + c.Logger().Error("Product attempted to use an account that already exists. Convert user to a bot "+ "account in the CLI by running 'mattermost user convert --bot'. If the user is an "+ "existing user account you want to preserve, change its username and restart the Mattermost server, "+ "after which the plugin will create a bot account with that name. For more information about bot "+ @@ -103,7 +103,7 @@ func (a *App) EnsureBot(c *request.Context, productID string, bot *model.Bot) (s } // CreateBot creates the given bot and corresponding user. -func (a *App) CreateBot(c *request.Context, bot *model.Bot) (*model.Bot, *model.AppError) { +func (a *App) CreateBot(c request.CTX, bot *model.Bot) (*model.Bot, *model.AppError) { vErr := bot.IsValidCreate() if vErr != nil { return nil, vErr @@ -391,7 +391,7 @@ func (a *App) GetBots(options *model.BotGetOptions) (model.BotList, *model.AppEr } // UpdateBotActive marks a bot as active or inactive, along with its corresponding user. -func (a *App) UpdateBotActive(c *request.Context, botUserId string, active bool) (*model.Bot, *model.AppError) { +func (a *App) UpdateBotActive(c request.CTX, botUserId string, active bool) (*model.Bot, *model.AppError) { user, nErr := a.Srv().Store.User().Get(context.Background(), botUserId) if nErr != nil { var nfErr *store.ErrNotFound @@ -498,7 +498,7 @@ func (a *App) UpdateBotOwner(botUserId, newOwnerId string) (*model.Bot, *model.A } // disableUserBots disables all bots owned by the given user. -func (a *App) disableUserBots(c *request.Context, userID string) *model.AppError { +func (a *App) disableUserBots(c request.CTX, userID string) *model.AppError { perPage := 20 for { options := &model.BotGetOptions{ @@ -516,7 +516,7 @@ func (a *App) disableUserBots(c *request.Context, userID string) *model.AppError for _, bot := range userBots { _, err := a.UpdateBotActive(c, bot.UserId, false) if err != nil { - mlog.Warn("Unable to deactivate bot.", mlog.String("bot_user_id", bot.UserId), mlog.Err(err)) + c.Logger().Warn("Unable to deactivate bot.", mlog.String("bot_user_id", bot.UserId), mlog.Err(err)) } } @@ -531,7 +531,7 @@ func (a *App) disableUserBots(c *request.Context, userID string) *model.AppError return nil } -func (a *App) notifySysadminsBotOwnerDeactivated(c *request.Context, userID string) *model.AppError { +func (a *App) notifySysadminsBotOwnerDeactivated(c request.CTX, userID string) *model.AppError { perPage := 25 botOptions := &model.BotGetOptions{ OwnerId: userID, diff --git a/app/import_functions.go b/app/import_functions.go index 75ec8ad364..44f89737a5 100644 --- a/app/import_functions.go +++ b/app/import_functions.go @@ -521,7 +521,7 @@ func (a *App) importUser(c request.CTX, data *UserImportData, dryRun bool) *mode pref := model.Preference{UserId: savedUser.Id, Category: model.PreferenceCategoryTutorialSteps, Name: savedUser.Id, Value: "0"} if err := a.Srv().Store.Preference().Save(model.Preferences{pref}); err != nil { - mlog.Warn("Encountered error saving tutorial preference", mlog.Err(err)) + c.Logger().Warn("Encountered error saving tutorial preference", mlog.Err(err)) } } else { @@ -584,14 +584,14 @@ func (a *App) importUser(c request.CTX, data *UserImportData, dryRun bool) *mode } if err != nil { - mlog.Warn("Unable to open the profile image.", mlog.Err(err)) + c.Logger().Warn("Unable to open the profile image.", mlog.Err(err)) } else { defer file.Close() if limitErr := checkImageLimits(file, *a.Config().FileSettings.MaxImageResolution); limitErr != nil { return model.NewAppError("SetProfileImage", "api.user.upload_profile_user.check_image_limits.app_error", nil, "", http.StatusBadRequest) } if err := a.SetProfileImageFromFile(c, savedUser.Id, file); err != nil { - mlog.Warn("Unable to set the profile image from a file.", mlog.Err(err)) + c.Logger().Warn("Unable to set the profile image from a file.", mlog.Err(err)) } } } @@ -1137,7 +1137,7 @@ func (a *App) importReplies(c *request.Context, data []ReplyImportData, post *mo reply.Message = *replyData.Message reply.CreateAt = *replyData.CreateAt if reply.CreateAt < post.CreateAt { - mlog.Warn("Reply CreateAt is before parent post CreateAt, setting it to parent post CreateAt", mlog.Int64("reply_create_at", reply.CreateAt), mlog.Int64("parent_create_at", post.CreateAt)) + c.Logger().Warn("Reply CreateAt is before parent post CreateAt, setting it to parent post CreateAt", mlog.Int64("reply_create_at", reply.CreateAt), mlog.Int64("parent_create_at", post.CreateAt)) reply.CreateAt = post.CreateAt } if replyData.Type != nil { diff --git a/app/opentracing/opentracing_layer.go b/app/opentracing/opentracing_layer.go index b2beba058e..cd6c85fc5d 100644 --- a/app/opentracing/opentracing_layer.go +++ b/app/opentracing/opentracing_layer.go @@ -1857,7 +1857,7 @@ func (a *OpenTracingAppLayer) CopyFileInfos(userID string, fileIDs []string) ([] return resultVar0, resultVar1 } -func (a *OpenTracingAppLayer) CreateBot(c *request.Context, bot *model.Bot) (*model.Bot, *model.AppError) { +func (a *OpenTracingAppLayer) CreateBot(c request.CTX, bot *model.Bot) (*model.Bot, *model.AppError) { origCtx := a.ctx span, newCtx := tracing.StartSpanWithParentByContext(a.ctx, "app.CreateBot") @@ -2323,7 +2323,7 @@ func (a *OpenTracingAppLayer) CreatePost(c request.CTX, post *model.Post, channe return resultVar0, resultVar1 } -func (a *OpenTracingAppLayer) CreatePostAsUser(c *request.Context, post *model.Post, currentSessionId string, setOnline bool) (*model.Post, *model.AppError) { +func (a *OpenTracingAppLayer) CreatePostAsUser(c request.CTX, post *model.Post, currentSessionId string, setOnline bool) (*model.Post, *model.AppError) { origCtx := a.ctx span, newCtx := tracing.StartSpanWithParentByContext(a.ctx, "app.CreatePostAsUser") @@ -3948,7 +3948,7 @@ func (a *OpenTracingAppLayer) EnableUserAccessToken(token *model.UserAccessToken return resultVar0 } -func (a *OpenTracingAppLayer) EnsureBot(c *request.Context, productID string, bot *model.Bot) (string, error) { +func (a *OpenTracingAppLayer) EnsureBot(c request.CTX, productID string, bot *model.Bot) (string, error) { origCtx := a.ctx span, newCtx := tracing.StartSpanWithParentByContext(a.ctx, "app.EnsureBot") @@ -16474,7 +16474,7 @@ func (a *OpenTracingAppLayer) UnregisterPluginCommand(pluginID string, teamID st a.app.UnregisterPluginCommand(pluginID, teamID, trigger) } -func (a *OpenTracingAppLayer) UpdateActive(c *request.Context, user *model.User, active bool) (*model.User, *model.AppError) { +func (a *OpenTracingAppLayer) UpdateActive(c request.CTX, user *model.User, active bool) (*model.User, *model.AppError) { origCtx := a.ctx span, newCtx := tracing.StartSpanWithParentByContext(a.ctx, "app.UpdateActive") @@ -16496,7 +16496,7 @@ func (a *OpenTracingAppLayer) UpdateActive(c *request.Context, user *model.User, return resultVar0, resultVar1 } -func (a *OpenTracingAppLayer) UpdateBotActive(c *request.Context, botUserId string, active bool) (*model.Bot, *model.AppError) { +func (a *OpenTracingAppLayer) UpdateBotActive(c request.CTX, botUserId string, active bool) (*model.Bot, *model.AppError) { origCtx := a.ctx span, newCtx := tracing.StartSpanWithParentByContext(a.ctx, "app.UpdateBotActive") diff --git a/app/post.go b/app/post.go index 797f1b6861..716b821984 100644 --- a/app/post.go +++ b/app/post.go @@ -46,7 +46,7 @@ func (s *postServiceWrapper) CreatePost(ctx *request.Context, post *model.Post) return s.app.CreatePostMissingChannel(ctx, post, true) } -func (a *App) CreatePostAsUser(c *request.Context, post *model.Post, currentSessionId string, setOnline bool) (*model.Post, *model.AppError) { +func (a *App) CreatePostAsUser(c request.CTX, post *model.Post, currentSessionId string, setOnline bool) (*model.Post, *model.AppError) { // Check that channel has not been deleted channel, errCh := a.Srv().Store.Channel().Get(post.ChannelId, true) if errCh != nil { @@ -83,7 +83,7 @@ func (a *App) CreatePostAsUser(c *request.Context, post *model.Post, currentSess isCRTReply := post.RootId != "" && a.IsCRTEnabledForUser(c, post.UserId) if !fromWebhook && !fromBot && !isCRTReply { if _, err := a.MarkChannelsAsViewed(c, []string{post.ChannelId}, post.UserId, currentSessionId, true); err != nil { - mlog.Warn( + c.Logger().Warn( "Encountered error updating last viewed", mlog.String("channel_id", post.ChannelId), mlog.String("user_id", post.UserId), diff --git a/app/user.go b/app/user.go index edeef970ff..844402d2f6 100644 --- a/app/user.go +++ b/app/user.go @@ -883,7 +883,7 @@ func (a *App) UpdatePasswordAsUser(c request.CTX, userID, currentPassword, newPa return a.UpdatePasswordSendEmail(c, user, newPassword, T("api.user.update_password.menu")) } -func (a *App) userDeactivated(c *request.Context, userID string) *model.AppError { +func (a *App) userDeactivated(c request.CTX, userID string) *model.AppError { a.SetStatusOffline(userID, false) user, err := a.GetUser(userID) @@ -928,7 +928,7 @@ func (a *App) invalidateUserChannelMembersCaches(c request.CTX, userID string) * return nil } -func (a *App) UpdateActive(c *request.Context, user *model.User, active bool) (*model.User, *model.AppError) { +func (a *App) UpdateActive(c request.CTX, user *model.User, active bool) (*model.User, *model.AppError) { user.UpdateAt = model.GetMillis() if active { user.DeleteAt = 0