s/Get(Master|Replica)X/Get\1/g (#29520)

Drop the legacy `X` suffix from `GetMasterX` and `GetReplicaX`. The
presence of the suffix suggests there's a `non-X` version: but in fact
we migrated these away a long time ago, so remove the cognitive
overhead.

As an aside, this additionally helps avoid trip up LLMs that interpret
this as "something to fix".

server/channels/app/platform/service_test.go

@@ -40,7 +40,7 @@ func TestReadReplicaDisabledBasedOnLicense(t *testing.T) {
 			ConfigStore(configStore),
 		)
 		require.NoError(t, err)
-		require.Same(t, ps.sqlStore.GetMasterX(), ps.sqlStore.GetReplicaX())
+		require.Same(t, ps.sqlStore.GetMaster(), ps.sqlStore.GetReplica())
 		require.Len(t, ps.Config().SqlSettings.DataSourceReplicas, 1)
 	})
 
@@ -56,7 +56,7 @@ func TestReadReplicaDisabledBasedOnLicense(t *testing.T) {
 			},
 		)
 		require.NoError(t, err)
-		require.NotSame(t, ps.sqlStore.GetMasterX(), ps.sqlStore.GetReplicaX())
+		require.NotSame(t, ps.sqlStore.GetMaster(), ps.sqlStore.GetReplica())
 		require.Len(t, ps.Config().SqlSettings.DataSourceReplicas, 1)
 	})
 
@@ -68,7 +68,7 @@ func TestReadReplicaDisabledBasedOnLicense(t *testing.T) {
 			ConfigStore(configStore),
 		)
 		require.NoError(t, err)
-		require.Same(t, ps.sqlStore.GetMasterX(), ps.sqlStore.GetSearchReplicaX())
+		require.Same(t, ps.sqlStore.GetMaster(), ps.sqlStore.GetSearchReplicaX())
 		require.Len(t, ps.Config().SqlSettings.DataSourceSearchReplicas, 1)
 	})
 
@@ -84,7 +84,7 @@ func TestReadReplicaDisabledBasedOnLicense(t *testing.T) {
 			},
 		)
 		require.NoError(t, err)
-		require.NotSame(t, ps.sqlStore.GetMasterX(), ps.sqlStore.GetSearchReplicaX())
+		require.NotSame(t, ps.sqlStore.GetMaster(), ps.sqlStore.GetSearchReplicaX())
 		require.Len(t, ps.Config().SqlSettings.DataSourceSearchReplicas, 1)
 	})
 }