[MM-40638] Type all of the websocket event names as a new type WebsocketEventType (#25454)
Co-authored-by: Sudheer Tripathi <sudheer@clearglass.com> Co-authored-by: Sudheer Tripathi <31629433+sudheer121@users.noreply.github.com> Co-authored-by: Sudheer Tripathi <tripathisudheer604@gmail.com>
Этот коммит содержится в:
коммит произвёл
GitHub
родитель
e1f72576fb
Коммит
51e73b681b
@@ -34,14 +34,14 @@ func TestWebSocketEvent(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestWebSocketEventImmutable(t *testing.T) {
|
||||
m := NewWebSocketEvent("some_event", NewId(), NewId(), NewId(), nil, "")
|
||||
m := NewWebSocketEvent(WebsocketEventPostEdited, NewId(), NewId(), NewId(), nil, "")
|
||||
|
||||
newM := m.SetEvent("new_event")
|
||||
newM := m.SetEvent(WebsocketEventPostDeleted)
|
||||
if newM == m {
|
||||
require.Fail(t, "pointers should not be the same")
|
||||
}
|
||||
require.NotEqual(t, m.EventType(), newM.EventType())
|
||||
require.Equal(t, newM.EventType(), "new_event")
|
||||
require.Equal(t, newM.EventType(), WebsocketEventPostDeleted)
|
||||
|
||||
newM = m.SetSequence(45)
|
||||
if newM == m {
|
||||
@@ -81,11 +81,11 @@ func TestWebSocketEventFromJSON(t *testing.T) {
|
||||
ev, err := WebSocketEventFromJSON(bytes.NewReader([]byte("junk")))
|
||||
require.Error(t, err)
|
||||
require.Nil(t, ev, "should not have parsed")
|
||||
data := []byte(`{"event": "test", "data": {"key": "val"}, "seq": 45, "broadcast": {"user_id": "userid"}}`)
|
||||
data := []byte(`{"event": "typing", "data": {"key": "val"}, "seq": 45, "broadcast": {"user_id": "userid"}}`)
|
||||
ev, err = WebSocketEventFromJSON(bytes.NewReader(data))
|
||||
require.NoError(t, err)
|
||||
require.NotNil(t, ev, "should have parsed")
|
||||
require.Equal(t, ev.EventType(), "test")
|
||||
require.Equal(t, ev.EventType(), WebsocketEventTyping)
|
||||
require.Equal(t, ev.GetSequence(), int64(45))
|
||||
require.Equal(t, ev.data, map[string]any{"key": "val"})
|
||||
require.Equal(t, ev.GetBroadcast(), &WebsocketBroadcast{UserId: "userid"})
|
||||
|
||||
Ссылка в новой задаче
Block a user