[MM-55277] Team's menu doesn't follow standard accessible keyboard behavior (#29917)

e2e-tests/cypress/tests/integration/channels/team_settings/closed_team_invite_by_email_spec.js

@@ -55,7 +55,7 @@ describe('Team Settings', () => {
 
     it('MM-T385 Invite new user to closed team using email invite', () => {
         // # Open 'Team Settings' modal
-        cy.uiOpenTeamMenu('Team Settings');
+        cy.uiOpenTeamMenu('Team settings');
 
         // * Check that the 'Team Settings' modal was opened
         cy.get('#teamSettingsModal').should('exist').within(() => {
@@ -75,7 +75,7 @@ describe('Team Settings', () => {
         });
 
         // # Open the 'Invite People' full screen modal
-        cy.uiOpenTeamMenu('Invite People');
+        cy.uiOpenTeamMenu('Invite people');
 
         // # Wait half a second to ensure that the modal has been fully loaded
         cy.wait(TIMEOUTS.HALF_SEC);

e2e-tests/cypress/tests/integration/channels/team_settings/create_a_team_spec.js

@@ -23,7 +23,7 @@ describe('Teams Suite', () => {
 
     it('MM-T383 Create a new team', () => {
         // # Open team menu and click "Create a Team"
-        cy.uiOpenTeamMenu('Create a Team');
+        cy.uiOpenTeamMenu('Create a team');
 
         // # Input team name as Team Test
         const teamName = 'Team Test';
@@ -69,7 +69,7 @@ describe('Teams Suite', () => {
 
 function tryReservedTeamURLAndVerifyError(teamURL) {
     // # Open team menu and click "Create a Team"
-    cy.uiOpenTeamMenu('Create a Team');
+    cy.uiOpenTeamMenu('Create a team');
 
     // # Input passed in team name
     cy.get('#teamNameInput').should('be.visible').type(teamURL);

e2e-tests/cypress/tests/integration/channels/team_settings/helpers.js

@@ -10,7 +10,7 @@ import {
 
 export const allowOnlyUserFromSpecificDomain = (domain) => {
     // # Open 'Team Settings' modal
-    cy.uiOpenTeamMenu('Team Settings');
+    cy.uiOpenTeamMenu('Team settings');
 
     // * Check that the 'Team Settings' modal was opened
     cy.get('#teamSettingsModal').should('exist').within(() => {
@@ -31,7 +31,7 @@ export const allowOnlyUserFromSpecificDomain = (domain) => {
 
 export const inviteUserByEmail = (email) => {
     // # Open team menu and click 'Invite People'
-    cy.uiOpenTeamMenu('Invite People');
+    cy.uiOpenTeamMenu('Invite people');
 
     // # Wait half a second to ensure that the modal has been fully loaded
     cy.wait(TIMEOUTS.HALF_SEC);

e2e-tests/cypress/tests/integration/channels/team_settings/invite_members_backdrop_spec.js

@@ -32,7 +32,7 @@ describe('Invite Members', () => {
             cy.visit('/');
 
             // # Open and select invite menu item
-            cy.uiOpenTeamMenu('Invite People');
+            cy.uiOpenTeamMenu('Invite people');
         });
 
         it('allows user to exit when there are no inputs', () => {

e2e-tests/cypress/tests/integration/channels/team_settings/invite_members_spec.js

@@ -111,7 +111,7 @@ describe('Invite Members', () => {
             cy.visit(`/${testTeam.name}/channels/town-square`);
 
             // # Open and select invite menu item
-            cy.uiOpenTeamMenu('Invite People');
+            cy.uiOpenTeamMenu('Invite people');
 
             // * Users emails input is focused by default
             cy.get('.users-emails-input__control--is-focused').should('be.visible');
@@ -181,7 +181,7 @@ function inviteUserToTeamAsMember(testUser, testTeam, user) {
     cy.visit(`/${testTeam.name}/channels/town-square`);
 
     // # Open and select invite menu item
-    cy.uiOpenTeamMenu('Invite People');
+    cy.uiOpenTeamMenu('Invite people');
 
     // * Verify Invite Members
     verifyInviteMembersModal(testTeam);
@@ -196,7 +196,7 @@ function inviteUserToTeamAsSysadmin(testTeam, user) {
     cy.visit(`/${testTeam.name}/channels/off-topic`);
 
     // # Open and select invite menu item
-    cy.uiOpenTeamMenu('Invite People');
+    cy.uiOpenTeamMenu('Invite people');
 
     // * Verify Invite Members
     verifyInviteMembersModal(testTeam);

e2e-tests/cypress/tests/integration/channels/team_settings/invite_user_to_closed_team_spec.js

@@ -34,7 +34,7 @@ describe('Team Settings', () => {
         const inviteFailedMessage = `The following email addresses do not belong to an accepted domain: ${invalidEmail}. Please contact your System Administrator for details.`;
 
         // # Open team menu and click 'Team Settings'
-        cy.uiOpenTeamMenu('Team Settings');
+        cy.uiOpenTeamMenu('Team settings');
 
         // * Check that the 'Team Settings' modal was opened
         cy.get('#teamSettingsModal').should('exist').within(() => {
@@ -55,7 +55,7 @@ describe('Team Settings', () => {
         });
 
         // # Open team menu and click 'Invite People'
-        cy.uiOpenTeamMenu('Invite People');
+        cy.uiOpenTeamMenu('Invite people');
 
         // # Invite user with valid email domain that is not in the team
         inviteNewMemberToTeam(newUser.email);

e2e-tests/cypress/tests/integration/channels/team_settings/join_closed_team_with_not_allowed_email_spec.js

@@ -42,7 +42,7 @@ describe('Team Settings', () => {
         stubClipboard().as('clipboard');
 
         // # Open team menu and click 'Team Settings'
-        cy.uiOpenTeamMenu('Team Settings');
+        cy.uiOpenTeamMenu('Team settings');
 
         // * Check that the 'Team Settings' modal was opened
         cy.get('#teamSettingsModal').should('exist').within(() => {
@@ -63,7 +63,7 @@ describe('Team Settings', () => {
         cy.uiClose();
 
         // # Open team menu and click 'Invite People'
-        cy.uiOpenTeamMenu('Invite People');
+        cy.uiOpenTeamMenu('Invite people');
 
         // # Get the invite URL
         cy.findByTestId('InviteView__copyInviteLink').should('be.visible').click();
@@ -94,7 +94,7 @@ describe('Team Settings', () => {
 
     it('MM-T2341 Cannot add a user to a team if the user\'s email is not from the correct domain', () => {
         // # Open team menu and click 'Team Settings'
-        cy.uiOpenTeamMenu('Team Settings');
+        cy.uiOpenTeamMenu('Team settings');
 
         // * Check that the 'Team Settings' modal was opened
         cy.get('#teamSettingsModal').should('exist').within(() => {
@@ -136,7 +136,7 @@ describe('Team Settings', () => {
                     cy.visit(`/${otherTeam.name}/channels/town-square`);
 
                     // # Open team menu and click 'Join Another Team'
-                    cy.uiOpenTeamMenu('Join Another Team');
+                    cy.uiOpenTeamMenu('Join another team');
 
                     // # Try to join the existing team
                     cy.get('.signup-team-dir').find(`#${testTeam.display_name.replace(' ', '_')}`).scrollIntoView().click();

e2e-tests/cypress/tests/integration/channels/team_settings/manage_members_spec.js

@@ -34,7 +34,7 @@ describe('Manage Members', () => {
         cy.visit(`/${testTeam.name}/channels/town-square`);
 
         // # Open team menu and click 'Manage Members'
-        cy.uiOpenTeamMenu('Manage Members');
+        cy.uiOpenTeamMenu('Manage members');
 
         // # Open member dropdown
         cy.get(`#teamMembersDropdown_${testUser.username}`).should('be.visible').click();
@@ -61,7 +61,7 @@ describe('Manage Members', () => {
                 cy.visit(`/${testTeam.name}/channels/town-square`);
 
                 // # Open team menu and click 'Manage Members'
-                cy.uiOpenTeamMenu('Manage Members');
+                cy.uiOpenTeamMenu('Manage members');
 
                 // # Open member dropdown
                 cy.get(`#teamMembersDropdown_${user.username}`).should('be.visible').click();
@@ -94,7 +94,7 @@ describe('Manage Members', () => {
                         cy.visit(`/${testTeam.name}/channels/town-square`);
 
                         // # Open team menu and click 'Manage Members'
-                        cy.uiOpenTeamMenu('Manage Members');
+                        cy.uiOpenTeamMenu('Manage members');
 
                         // # Open member dropdown
                         cy.get(`#teamMembersDropdown_${user.username}`).should('be.visible').click();
@@ -139,7 +139,7 @@ describe('Manage Members', () => {
                 cy.visit(`/${testTeam.name}/channels/town-square`);
 
                 // # Open team menu and click 'Manage Members'
-                cy.uiOpenTeamMenu('Manage Members');
+                cy.uiOpenTeamMenu('Manage members');
 
                 // # Open member dropdown
                 cy.get(`#teamMembersDropdown_${user.username}`).should('be.visible').click();

e2e-tests/cypress/tests/integration/channels/team_settings/remove_team_icon_spec.js

@@ -61,7 +61,7 @@ describe('Teams Settings', () => {
 
 function openTeamSettingsDialog() {
     // # Open team menu and click 'Team Settings'
-    cy.uiOpenTeamMenu('Team Settings');
+    cy.uiOpenTeamMenu('Team settings');
 
     // * Verify the team settings dialog is open
     cy.get('#teamSettingsModalLabel').should('be.visible').and('contain', 'Team Settings');

e2e-tests/cypress/tests/integration/channels/team_settings/teammates_pagination_spec.js

@@ -50,7 +50,7 @@ describe('Teams Suite', () => {
 
     it('MM-T384 Team Admin can use Next button to page through list in Manage Members', () => {
         // # Open team menu and click "Manage Members"
-        cy.uiOpenTeamMenu('Manage Members');
+        cy.uiOpenTeamMenu('Manage members');
 
         // * Check Manage Members modal dialog
         cy.get('#teamMemberModalLabel').should('be.visible');

e2e-tests/cypress/tests/integration/channels/team_settings/teams_spec.js

@@ -41,7 +41,7 @@ describe('Teams Suite', () => {
         cy.url().should('include', `/${testTeam.name}/channels/town-square`);
 
         // # Open team menu and click "Manage Members"
-        cy.uiOpenTeamMenu('Leave Team');
+        cy.uiOpenTeamMenu('Leave team');
 
         // * Check that the "leave team modal" opened up
         cy.get('#leaveTeamModal').should('be.visible');
@@ -75,8 +75,8 @@ describe('Teams Suite', () => {
 
             // # Open team menu and click "Invite People"
             cy.uiOpenTeamMenu();
-            cy.uiGetLHSTeamMenu().findByText('Add people to the team');
-            cy.uiGetLHSTeamMenu().findByText('Invite People').click().wait(TIMEOUTS.HALF_SEC);
+            cy.uiGetLHSTeamMenu().find('div.label-elements > span:nth-child(2)').should('have.text', 'Add or invite people to the team');
+            cy.uiGetLHSTeamMenu().find("li span:contains('Invite people')").should('have.text', 'Invite people').click().wait(TIMEOUTS.HALF_SEC);
 
             // * Check that the Invitation Modal opened up
             cy.findByTestId('invitationModal', {timeout: TIMEOUTS.HALF_SEC}).should('be.visible');
@@ -184,7 +184,7 @@ describe('Teams Suite', () => {
         cy.visit(`/${testTeam.name}/channels/town-square`);
 
         // # Open team menu and click "Team Settings"
-        cy.uiOpenTeamMenu('Team Settings');
+        cy.uiOpenTeamMenu('Team settings');
 
         // # Go to Access section
         cy.get('#accessButton').click();
@@ -208,7 +208,7 @@ describe('Teams Suite', () => {
         cy.visit(`/${testTeam.name}/channels/town-square`);
 
         // # Open team menu and click "Team Settings"
-        cy.uiOpenTeamMenu('Team Settings');
+        cy.uiOpenTeamMenu('Team settings');
 
         // # Click on the team name menu item
         cy.findByText('Team Name').should('be.visible').click();
@@ -236,7 +236,7 @@ describe('Teams Suite', () => {
         cy.visit(`/${testTeam.name}/channels/town-square`);
 
         // # Open team menu and click "Team Settings"
-        cy.uiOpenTeamMenu('Team Settings');
+        cy.uiOpenTeamMenu('Team settings');
 
         // # Change team description in the input
         cy.get('#teamDescription').should('be.visible').clear().type(teamDescription);
@@ -246,7 +246,7 @@ describe('Teams Suite', () => {
         cy.uiSaveAndClose();
 
         // # Open team menu and click "Team Settings"
-        cy.uiOpenTeamMenu('Team Settings');
+        cy.uiOpenTeamMenu('Team settings');
 
         // * Verify team description is updated
         cy.get('#teamDescription').should('have.text', teamDescription);
@@ -257,7 +257,7 @@ describe('Teams Suite', () => {
         cy.visit(`/${testTeam.name}/channels/town-square`);
 
         // # Open team menu and click "Team Settings"
-        cy.uiOpenTeamMenu('Team Settings');
+        cy.uiOpenTeamMenu('Team settings');
 
         // # Go to Access section
         cy.get('#accessButton').click();
@@ -296,7 +296,7 @@ describe('Teams Suite', () => {
         cy.visit(`/${testTeam.name}/channels/town-square`);
 
         // # Open team menu and click "Team Settings"
-        cy.uiOpenTeamMenu('Team Settings');
+        cy.uiOpenTeamMenu('Team settings');
 
         // # Go to Access section
         cy.get('#accessButton').click();
@@ -314,7 +314,7 @@ describe('Teams Suite', () => {
         cy.visit(`/${testTeam.name}/channels/town-square`);
 
         // # Open team menu and click "Join Another Team"
-        cy.uiOpenTeamMenu('Join Another Team');
+        cy.uiOpenTeamMenu('Join another team');
 
         // # Verify the original test team isn't on the list
         cy.get('.signup-team-dir').children().should('not.contain', `#${testTeam.name.charAt(0).toUpperCase() + testTeam.name.slice(1)}`);
@@ -329,7 +329,7 @@ describe('Teams Suite', () => {
         cy.visit(`/${testTeam.name}/channels/town-square`);
 
         // # Open team menu and click "View Members"
-        cy.uiOpenTeamMenu('View Members');
+        cy.uiOpenTeamMenu('View members');
         cy.wait(TIMEOUTS.HALF_SEC);
         cy.get('#searchUsersInput').should('be.visible').type('sysadmin');
         cy.get('.more-modal__list').should('be.visible').children().should('have.length', 1);
@@ -341,7 +341,7 @@ function removeTeamMember(teamName, username) {
     cy.visit(`/${teamName}`);
 
     // # Open team menu and click "Manage Members"
-    cy.uiOpenTeamMenu('Manage Members');
+    cy.uiOpenTeamMenu('Manage members');
 
     cy.get(`#teamMembersDropdown_${username}`).should('be.visible').click();
     cy.get('#removeFromTeam').should('be.visible').click();