From 4dbf1f8c26f3a44f04ad229caa6f38aadd769dcc Mon Sep 17 00:00:00 2001 From: Julien Tant <785518+JulienTant@users.noreply.github.com> Date: Mon, 6 Nov 2023 15:24:59 -0700 Subject: [PATCH] [MM-54029] IDP descriptor can any string (#24250) Co-authored-by: Mattermost Build --- server/i18n/en.json | 2 +- server/public/model/config.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/i18n/en.json b/server/i18n/en.json index 7bcfb7fc7b..8000bd55f0 100644 --- a/server/i18n/en.json +++ b/server/i18n/en.json @@ -8860,7 +8860,7 @@ }, { "id": "model.config.is_valid.saml_idp_descriptor_url.app_error", - "translation": "Identity Provider Issuer URL must be a valid URL and start with http:// or https://." + "translation": "Identity Provider Issuer URL cannot be an empty string." }, { "id": "model.config.is_valid.saml_idp_url.app_error", diff --git a/server/public/model/config.go b/server/public/model/config.go index 60378dfe3d..4adb681bbe 100644 --- a/server/public/model/config.go +++ b/server/public/model/config.go @@ -3794,7 +3794,7 @@ func (s *SamlSettings) isValid() *AppError { return NewAppError("Config.IsValid", "model.config.is_valid.saml_idp_url.app_error", nil, "", http.StatusBadRequest) } - if *s.IdpDescriptorURL == "" || !IsValidHTTPURL(*s.IdpDescriptorURL) { + if *s.IdpDescriptorURL == "" { return NewAppError("Config.IsValid", "model.config.is_valid.saml_idp_descriptor_url.app_error", nil, "", http.StatusBadRequest) }