PLT-4602 Fix misaligned close button and fix Android icon rendering bug (#4492)
* PLT-4602 Fix horizontal alignment for .close__button Reduce negative left margin to fix miscalculated center-positioning. * PLT-4602 Fix dropdown close icon rendering bug on Android The combination of using a unicode character and a pseudo element was too problematic, so I added a new custom icon svg CLOSE_ICON that renders consistently on all browsers. * PLT-4602 Use font-family fix, remove <svg> You were correct @hmhealey, the problem was that the unicode characters were rendering as different fonts: Open Sans and Helvetica Neue!
Этот коммит содержится в:
коммит произвёл
Harrison Healey
родитель
13dcccc60b
Коммит
4b3eceee70
@@ -546,6 +546,12 @@ export default class Navbar extends React.Component {
|
|||||||
{deleteChannelOption}
|
{deleteChannelOption}
|
||||||
{leaveChannelOption}
|
{leaveChannelOption}
|
||||||
{toggleFavoriteOption}
|
{toggleFavoriteOption}
|
||||||
|
<div
|
||||||
|
className='close visible-xs-block'
|
||||||
|
onClick={() => this.refs.headerOverlay.hide()}
|
||||||
|
>
|
||||||
|
{'×'}
|
||||||
|
</div>
|
||||||
</ul>
|
</ul>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
@@ -671,7 +677,7 @@ export default class Navbar extends React.Component {
|
|||||||
options={{singleline: true, mentionHighlight: false}}
|
options={{singleline: true, mentionHighlight: false}}
|
||||||
/>
|
/>
|
||||||
<div
|
<div
|
||||||
className='close__icon visible-xs-block'
|
className='close visible-xs-block'
|
||||||
onClick={() => this.refs.headerOverlay.hide()}
|
onClick={() => this.refs.headerOverlay.hide()}
|
||||||
>
|
>
|
||||||
{'×'}
|
{'×'}
|
||||||
@@ -721,7 +727,7 @@ export default class Navbar extends React.Component {
|
|||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
<div
|
<div
|
||||||
className='close__icon visible-xs-block'
|
className='close visible-xs-block'
|
||||||
onClick={() => this.refs.headerOverlay.hide()}
|
onClick={() => this.refs.headerOverlay.hide()}
|
||||||
>
|
>
|
||||||
{'×'}
|
{'×'}
|
||||||
|
|||||||
@@ -38,21 +38,24 @@
|
|||||||
padding: 15px 20px 100px;
|
padding: 15px 20px 100px;
|
||||||
}
|
}
|
||||||
|
|
||||||
.close__icon {
|
.close {
|
||||||
@include border-radius(50%);
|
font-family: 'Open Sans', sans-serif;
|
||||||
border: 1px solid $white;
|
|
||||||
bottom: 25px;
|
|
||||||
color: $white;
|
|
||||||
display: block;
|
display: block;
|
||||||
font-size: 23px;
|
|
||||||
font-weight: 300;
|
|
||||||
height: 30px;
|
|
||||||
left: 50%;
|
|
||||||
line-height: 23px;
|
|
||||||
margin-left: -25px;
|
|
||||||
position: fixed;
|
position: fixed;
|
||||||
text-align: center;
|
bottom: 25px;
|
||||||
|
height: 30px;
|
||||||
width: 30px;
|
width: 30px;
|
||||||
|
margin-left: -15px;
|
||||||
|
left: 50%;
|
||||||
|
font-size: 23px;
|
||||||
|
line-height: 27px;
|
||||||
|
border-radius: 50%;
|
||||||
|
border: 1px solid $white;
|
||||||
|
text-align: center;
|
||||||
|
opacity: 1;
|
||||||
|
text-shadow: none;
|
||||||
|
color: white;
|
||||||
|
font-weight: 200;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -752,22 +755,24 @@
|
|||||||
top: 42px;
|
top: 42px;
|
||||||
width: 100%;
|
width: 100%;
|
||||||
|
|
||||||
&:after {
|
.close {
|
||||||
@include border-radius(50%);
|
font-family: 'Open Sans', sans-serif;
|
||||||
border: 1px solid $white;
|
|
||||||
bottom: 25px;
|
|
||||||
color: $white;
|
|
||||||
content: '\D7';
|
|
||||||
display: block;
|
display: block;
|
||||||
font-size: 23px;
|
|
||||||
font-weight: 300;
|
|
||||||
height: 30px;
|
|
||||||
left: 50%;
|
|
||||||
line-height: 27px;
|
|
||||||
margin-left: -25px;
|
|
||||||
position: fixed;
|
position: fixed;
|
||||||
text-align: center;
|
bottom: 25px;
|
||||||
|
height: 30px;
|
||||||
width: 30px;
|
width: 30px;
|
||||||
|
margin-left: -15px;
|
||||||
|
left: 50%;
|
||||||
|
font-size: 23px;
|
||||||
|
line-height: 27px;
|
||||||
|
border-radius: 50%;
|
||||||
|
border: 1px solid $white;
|
||||||
|
text-align: center;
|
||||||
|
opacity: 1;
|
||||||
|
text-shadow: none;
|
||||||
|
color: white;
|
||||||
|
font-weight: 200;
|
||||||
}
|
}
|
||||||
|
|
||||||
> li {
|
> li {
|
||||||
|
|||||||
Ссылка в новой задаче
Block a user