diff --git a/app/diagnostics.go b/app/diagnostics.go index 0568f87396..de7fa52e73 100644 --- a/app/diagnostics.go +++ b/app/diagnostics.go @@ -14,7 +14,7 @@ import ( ) const ( - SEGMENT_KEY = "fwb7VPbFeQ7SKp3wHm1RzFUuXZudqVok" + SEGMENT_KEY = "placeholder_segment_key" TRACK_CONFIG_SERVICE = "config_service" TRACK_CONFIG_TEAM = "config_team" @@ -59,7 +59,11 @@ const ( var client *analytics.Client func (a *App) SendDailyDiagnostics() { - if *a.Config().LogSettings.EnableDiagnostics && a.IsLeader() { + a.sendDailyDiagnostics(false) +} + +func (a *App) sendDailyDiagnostics(override bool) { + if *a.Config().LogSettings.EnableDiagnostics && a.IsLeader() && (!strings.Contains(SEGMENT_KEY, "placeholder") || override) { a.initDiagnostics("") a.trackActivity() a.trackConfig() diff --git a/app/diagnostics_test.go b/app/diagnostics_test.go index d4b1e9db63..39b522e2c5 100644 --- a/app/diagnostics_test.go +++ b/app/diagnostics_test.go @@ -99,7 +99,7 @@ func TestDiagnostics(t *testing.T) { }) t.Run("SendDailyDiagnostics", func(t *testing.T) { - th.App.SendDailyDiagnostics() + th.App.sendDailyDiagnostics(true) info := "" // Collect the info sent. @@ -147,10 +147,21 @@ func TestDiagnostics(t *testing.T) { } }) + t.Run("SendDailyDiagnosticsNoSegmentKey", func(t *testing.T) { + th.App.SendDailyDiagnostics() + + select { + case <-data: + t.Fatal("Should not send diagnostics when the segment key is not set") + case <-time.After(time.Second * 1): + // Did not receive diagnostics + } + }) + t.Run("SendDailyDiagnosticsDisabled", func(t *testing.T) { th.App.UpdateConfig(func(cfg *model.Config) { *cfg.LogSettings.EnableDiagnostics = false }) - th.App.SendDailyDiagnostics() + th.App.sendDailyDiagnostics(true) select { case <-data: