diff --git a/app/server.go b/app/server.go index d8568011f7..827367dc06 100644 --- a/app/server.go +++ b/app/server.go @@ -215,8 +215,9 @@ func NewServer(options ...Option) (*Server, error) { mlog.Info(fmt.Sprintf("Current version is %v (%v/%v/%v/%v)", model.CurrentVersion, model.BuildNumber, model.BuildDate, model.BuildHash, model.BuildHashEnterprise)) mlog.Info(fmt.Sprintf("Enterprise Enabled: %v", model.BuildEnterpriseReady)) + pwd, _ := os.Getwd() - mlog.Info(fmt.Sprintf("Current working directory is %v", pwd)) + mlog.Info("Printing current working", mlog.String("directory", pwd)) mlog.Info("Loaded config", mlog.String("source", s.configStore.String())) s.checkPushNotificationServerUrl() @@ -244,7 +245,7 @@ func NewServer(options ...Option) (*Server, error) { } if err := s.Store.Status().ResetAll(); err != nil { - mlog.Error(fmt.Sprint("Error to reset the server status.", err.Error())) + mlog.Error("Error to reset the server status.", mlog.Err(err)) } if s.joinCluster && s.Cluster != nil { @@ -310,7 +311,7 @@ func (s *Server) StopHTTPServer() { didShutdown := false for s.didFinishListen != nil && !didShutdown { if err := s.Server.Shutdown(ctx); err != nil { - mlog.Warn(err.Error()) + mlog.Warn("Unable to shutdown server", mlog.Err(err)) } timer := time.NewTimer(time.Millisecond * 50) select { @@ -332,7 +333,7 @@ func (s *Server) Shutdown() error { err := s.shutdownDiagnostics() if err != nil { - mlog.Error(fmt.Sprintf("Unable to cleanly shutdown diagnostic client: %s", err)) + mlog.Error("Unable to cleanly shutdown diagnostic client", mlog.Err(err)) } s.StopHTTPServer() @@ -502,7 +503,7 @@ func (s *Server) Start() error { if *s.Config().ServiceSettings.Forward80To443 { if host, port, err := net.SplitHostPort(addr); err != nil { - mlog.Error("Unable to setup forwarding: " + err.Error()) + mlog.Error("Unable to setup forwarding", mlog.Err(err)) } else if port != "443" { return fmt.Errorf(utils.T("api.server.start_server.forward80to443.enabled_but_listening_on_wrong_port"), port) } else { @@ -519,7 +520,7 @@ func (s *Server) Start() error { go func() { redirectListener, err := net.Listen("tcp", httpListenAddress) if err != nil { - mlog.Error("Unable to setup forwarding: " + err.Error()) + mlog.Error("Unable to setup forwarding", mlog.Err(err)) return } defer redirectListener.Close() @@ -605,7 +606,7 @@ func (s *Server) Start() error { } if err != nil && err != http.ErrServerClosed { - mlog.Critical(fmt.Sprintf("Error starting server, err:%v", err)) + mlog.Critical("Error starting server", mlog.Err(err)) time.Sleep(time.Second) }