From 47c527ec2a0f6a0124bcd0146223fb24f87f7c0c Mon Sep 17 00:00:00 2001 From: Christopher Speller Date: Mon, 15 Apr 2019 08:21:12 -0700 Subject: [PATCH] Documenting OnConfigurationChange being called before OnActivate. (#10597) --- plugin/hooks.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugin/hooks.go b/plugin/hooks.go index 03f7484d77..c6263c293a 100644 --- a/plugin/hooks.go +++ b/plugin/hooks.go @@ -44,7 +44,7 @@ const ( type Hooks interface { // OnActivate is invoked when the plugin is activated. If an error is returned, the plugin // will be terminated. The plugin will not receive hooks until after OnActivate returns - // without error. + // without error. OnConfigurationChange will be called once before OnActivate. OnActivate() error // Implemented returns a list of hooks that are implemented by the plugin. @@ -58,7 +58,7 @@ type Hooks interface { // OnConfigurationChange is invoked when configuration changes may have been made. Any // returned error is logged, but does not stop the plugin. You must be prepared to handle - // a configuration failure gracefully. + // a configuration failure gracefully. It is called once before OnActivate. OnConfigurationChange() error // ServeHTTP allows the plugin to implement the http.Handler interface. Requests destined for