Pass a logger instead of embedding on job (#24650)

* pass a logger instead of embedding on job

* leverage mlog.Millis

* use worker logger with HandleJobPanic

* rely on existing LogClone instead

* guard Job.LogClone against nil Job

* s/workername/worker_name

* Revert "rely on existing LogClone instead"

This reverts commit 17303cbac90d4b01815abca1309b78b97de368fb.

* Revert "guard Job.LogClone against nil Job"

This reverts commit f1ae22dee58d76f084582857830ffe8d4c546d7e.

server/channels/app/job_test.go

@@ -22,7 +22,6 @@ func TestGetJob(t *testing.T) {
 		Id:     model.NewId(),
 		Status: model.NewId(),
 	}
-	status.InitLogger(th.TestLogger)
 
 	_, err := th.App.Srv().Store().Job().Save(status)
 	require.NoError(t, err)
@@ -240,8 +239,6 @@ func TestGetJobByType(t *testing.T) {
 	}
 
 	for _, status := range statuses {
-		status.InitLogger(th.TestLogger)
-
 		_, err := th.App.Srv().Store().Job().Save(status)
 		require.NoError(t, err)
 		defer th.App.Srv().Store().Job().Delete(status.Id)
@@ -286,8 +283,6 @@ func TestGetJobsByTypes(t *testing.T) {
 	}
 
 	for _, status := range statuses {
-		status.InitLogger(th.TestLogger)
-
 		_, err := th.App.Srv().Store().Job().Save(status)
 		require.NoError(t, err)
 		defer th.App.Srv().Store().Job().Delete(status.Id)