Fix. Replace t.fatal() calls to testify assert/require calls (#12084)

app/opengraph_test.go

@@ -4,6 +4,7 @@
 package app
 
 import (
+	"github.com/stretchr/testify/require"
 	"strings"
 	"testing"
 
@@ -108,22 +109,17 @@ func TestMakeOpenGraphURLsAbsolute(t *testing.T) {
 	} {
 		t.Run(name, func(t *testing.T) {
 			og := opengraph.NewOpenGraph()
-			if err := og.ProcessHTML(strings.NewReader(tc.HTML)); err != nil {
+			err := og.ProcessHTML(strings.NewReader(tc.HTML))
-				t.Fatal(err)
+			require.Nil(t, err)
-			}
 
 			makeOpenGraphURLsAbsolute(og, tc.RequestURL)
 
-			if og.URL != tc.URL {
+			assert.Equalf(t, og.URL, tc.URL, "incorrect url, expected %v, got %v", tc.URL, og.URL)
-				t.Fatalf("incorrect url, expected %v, got %v", tc.URL, og.URL)
-			}
 
 			if len(og.Images) > 0 {
-				if og.Images[0].URL != tc.ImageURL {
+				assert.Equalf(t, og.Images[0].URL, tc.ImageURL, "incorrect image url, expected %v, got %v", tc.ImageURL, og.Images[0].URL)
-					t.Fatalf("incorrect image url, expected %v, got %v", tc.ImageURL, og.Images[0].URL)
+			} else {
-				}
+				assert.Empty(t, tc.ImageURL, "missing image url, expected %v, got nothing", tc.ImageURL)
-			} else if tc.ImageURL != "" {
-				t.Fatalf("missing image url, expected %v, got nothing", tc.ImageURL)
 			}
 		})
 	}