Made code for the member popover count a bit more robust to hopefully prevent issues involving old data

Этот коммит содержится в:
hmhealey
2015-11-13 09:34:50 -05:00
родитель 0baa1bfe94
Коммит 43cb220dcd

Просмотреть файл

@@ -69,7 +69,6 @@ export default class PopoverListMembers extends React.Component {
render() { render() {
let popoverHtml = []; let popoverHtml = [];
let countText = '-';
const members = this.props.members; const members = this.props.members;
const teamMembers = UserStore.getProfilesUsernameMap(); const teamMembers = UserStore.getProfilesUsernameMap();
const currentUserId = UserStore.getCurrentId(); const currentUserId = UserStore.getCurrentId();
@@ -148,13 +147,20 @@ export default class PopoverListMembers extends React.Component {
); );
} }
}); });
}
const count = this.props.memberCount; let count = this.props.memberCount;
if (count > 20) { let countText = '-';
countText = '20+';
} else if (count > 0) { // fall back to checking the length of the member list if the count isn't set
countText = count.toString(); if (!count && members) {
} count = members.length;
}
if (count > 20) {
countText = '20+';
} else if (count > 0) {
countText = count.toString();
} }
return ( return (
@@ -194,6 +200,6 @@ export default class PopoverListMembers extends React.Component {
PopoverListMembers.propTypes = { PopoverListMembers.propTypes = {
members: React.PropTypes.array.isRequired, members: React.PropTypes.array.isRequired,
memberCount: React.PropTypes.number.isRequired, memberCount: React.PropTypes.number,
channelId: React.PropTypes.string.isRequired channelId: React.PropTypes.string.isRequired
}; };