[MM-56616] Changes for the DM for batch reporting (#26019)

* [MM-56616] Changes for the DM for batch reporting

* Use requesting user's locale

* Fix lint

* Remove unnecessary test

* Move back to file attachment

* Add default API case

* Fix i18n

* Hardcode the CSV string

server/channels/jobs/batch_report_worker.go

@@ -18,7 +18,7 @@ import (
 type BatchReportWorkerAppIFace interface {
 	SaveReportChunk(format string, prefix string, count int, reportData []model.ReportableObject) *model.AppError
 	CompileReportChunks(format string, prefix string, numberOfChunks int, headers []string) *model.AppError
-	SendReportToUser(rctx request.CTX, userID string, jobId string, format string) *model.AppError
+	SendReportToUser(rctx request.CTX, job *model.Job, format string) *model.AppError
 	CleanupReportChunks(format string, prefix string, numberOfChunks int) *model.AppError
 }
 
@@ -113,10 +113,6 @@ func (worker *BatchReportWorker) processChunk(job *model.Job, reportData []model
 }
 
 func (worker *BatchReportWorker) complete(rctx request.CTX, job *model.Job) error {
-	requestingUserId := job.Data["requesting_user_id"]
-	if requestingUserId == "" {
-		return errors.New("No user to send the report to")
-	}
 	fileCount, err := getFileCount(job.Data)
 	if err != nil {
 		return err
@@ -131,7 +127,7 @@ func (worker *BatchReportWorker) complete(rctx request.CTX, job *model.Job) erro
 		worker.app.CleanupReportChunks(worker.reportFormat, job.Id, fileCount)
 	}()
 
-	if appErr = worker.app.SendReportToUser(rctx, requestingUserId, job.Id, worker.reportFormat); appErr != nil {
+	if appErr = worker.app.SendReportToUser(rctx, job, worker.reportFormat); appErr != nil {
 		return appErr
 	}
 

server/channels/jobs/batch_report_worker_test.go

@@ -23,7 +23,7 @@ func (rma *ReportMockApp) SaveReportChunk(format string, prefix string, count in
 func (rma *ReportMockApp) CompileReportChunks(format string, prefix string, numberOfChunks int, headers []string) *model.AppError {
 	return nil
 }
-func (rma *ReportMockApp) SendReportToUser(rctx request.CTX, userID string, jobId string, format string) *model.AppError {
+func (rma *ReportMockApp) SendReportToUser(rctx request.CTX, job *model.Job, format string) *model.AppError {
 	return nil
 }
 func (rma *ReportMockApp) CleanupReportChunks(format string, prefix string, numberOfChunks int) *model.AppError {
@@ -129,21 +129,4 @@ func TestBatchReportWorker(t *testing.T) {
 
 		th.WaitForJobStatus(t, job, model.JobStatusError)
 	})
-
-	t.Run("should fail if there is no user id to send the report to", func(t *testing.T) {
-		th := Setup(t).InitBasic()
-		defer th.TearDown()
-
-		var worker model.Worker
-		var job *model.Job
-		worker, job = setupBatchWorker(t, th, func(data model.StringMap) ([]model.ReportableObject, model.StringMap, bool, error) {
-			go worker.Stop() // Shut down the worker right after this
-			return []model.ReportableObject{}, make(model.StringMap), true, nil
-		})
-
-		// Queue the work to be done
-		worker.JobChannel() <- *job
-
-		th.WaitForJobStatus(t, job, model.JobStatusError)
-	})
 }