[MM-31359] remove duplicated error logs (#16583)

* remove duplicated error logs

* reflect review comments

* add context

* add error details

api4/job.go

@@ -10,7 +10,6 @@ import (
 	"time"
 
 	"github.com/mattermost/mattermost-server/v5/audit"
-	"github.com/mattermost/mattermost-server/v5/mlog"
 	"github.com/mattermost/mattermost-server/v5/model"
 )
 
@@ -65,7 +64,6 @@ func downloadJob(c *Context, w http.ResponseWriter, r *http.Request) {
 
 	job, err := c.App.GetJob(c.Params.JobId)
 	if err != nil {
-		mlog.Error(err.Error())
 		c.Err = err
 		return
 	}
@@ -80,7 +78,6 @@ func downloadJob(c *Context, w http.ResponseWriter, r *http.Request) {
 	filePath := filepath.Join(FILE_PATH, fileName)
 	fileReader, err := c.App.FileReader(filePath)
 	if err != nil {
-		mlog.Error(err.Error())
 		c.Err = err
 		c.Err.StatusCode = http.StatusNotFound
 		return
@@ -91,7 +88,6 @@ func downloadJob(c *Context, w http.ResponseWriter, r *http.Request) {
 	// already sets that for us
 	err = writeFileResponse(fileName, FILE_MIME, 0, time.Unix(0, job.LastActivityAt*int64(1000*1000)), *c.App.Config().ServiceSettings.WebserverMode, fileReader, true, w, r)
 	if err != nil {
-		mlog.Error(err.Error())
 		c.Err = err
 		return
 	}

api4/websocket.go

@@ -7,7 +7,6 @@ import (
 	"net/http"
 
 	"github.com/gorilla/websocket"
-	"github.com/mattermost/mattermost-server/v5/mlog"
 	"github.com/mattermost/mattermost-server/v5/model"
 )
 
@@ -25,7 +24,6 @@ func connectWebSocket(c *Context, w http.ResponseWriter, r *http.Request) {
 
 	ws, err := upgrader.Upgrade(w, r, nil)
 	if err != nil {
-		mlog.Error("websocket connect err.", mlog.Err(err))
 		c.Err = model.NewAppError("connect", "api.web_socket.connect.upgrade.app_error", nil, "", http.StatusInternalServerError)
 		return
 	}