Goodbye, GraphQL (#24827)

```release-note NONE ```
2023-10-12 09:47:35 +05:30
--- a/server/channels/store/storetest/channel_store.go
+++ b/server/channels/store/storetest/channel_store.go
@@ -94,7 +94,6 @@ func TestChannelStore(t *testing.T, ss store.Store, s SqlStore) {
 	t.Run("RemoveMembers", func(t *testing.T) { testChannelRemoveMembers(t, ss) })
 	t.Run("ChannelDeleteMemberStore", func(t *testing.T) { testChannelDeleteMemberStore(t, ss) })
 	t.Run("GetChannels", func(t *testing.T) { testChannelStoreGetChannels(t, ss) })
-	t.Run("GetChannelsWithCursor", func(t *testing.T) { testChannelStoreGetChannelsWithCursor(t, ss) })
 	t.Run("GetChannelsByUser", func(t *testing.T) { testChannelStoreGetChannelsByUser(t, ss) })
 	t.Run("GetAllChannels", func(t *testing.T) { testChannelStoreGetAllChannels(t, ss, s) })
 	t.Run("GetMoreChannels", func(t *testing.T) { testChannelStoreGetMoreChannels(t, ss) })
@@ -103,7 +102,6 @@ func TestChannelStore(t *testing.T, ss store.Store, s SqlStore) {
 	t.Run("GetPublicChannelsByIdsForTeam", func(t *testing.T) { testChannelStoreGetPublicChannelsByIdsForTeam(t, ss) })
 	t.Run("GetChannelCounts", func(t *testing.T) { testChannelStoreGetChannelCounts(t, ss) })
 	t.Run("GetMembersForUser", func(t *testing.T) { testChannelStoreGetMembersForUser(t, ss) })
-	t.Run("GetMembersForUserWithCursor", func(t *testing.T) { testChannelStoreGetMembersForUserWithCursor(t, ss) })
 	t.Run("GetMembersForUserWithPagination", func(t *testing.T) { testChannelStoreGetMembersForUserWithPagination(t, ss) })
 	t.Run("CountPostsAfter", func(t *testing.T) { testCountPostsAfter(t, ss) })
 	t.Run("CountUrgentPostsAfter", func(t *testing.T) { testCountUrgentPostsAfter(t, ss) })
@@ -3607,163 +3605,6 @@ func testChannelStoreGetChannels(t *testing.T, ss store.Store) {
 	ss.Channel().InvalidateAllChannelMembersForUser(m1.UserId)
 }

-func testChannelStoreGetChannelsWithCursor(t *testing.T, ss store.Store) {
-	teamID := model.NewId()
-	o1 := &model.Channel{}
-	o1.TeamId = teamID
-	o1.DisplayName = "Channel1"
-	o1.Name = NewTestId()
-	o1.Type = model.ChannelTypeOpen
-	var nErr error
-	o1, nErr = ss.Channel().Save(o1, -1)
-	require.NoError(t, nErr)
-
-	o2 := model.Channel{}
-	o2.TeamId = teamID
-	o2.DisplayName = "Channel2"
-	o2.Name = NewTestId()
-	o2.Type = model.ChannelTypeOpen
-	_, nErr = ss.Channel().Save(&o2, -1)
-	require.NoError(t, nErr)
-
-	o3 := model.Channel{}
-	o3.TeamId = teamID
-	o3.DisplayName = "Channel3"
-	o3.Name = NewTestId()
-	o3.Type = model.ChannelTypeOpen
-	_, nErr = ss.Channel().Save(&o3, -1)
-	require.NoError(t, nErr)
-
-	m1 := model.ChannelMember{}
-	m1.ChannelId = o1.Id
-	m1.UserId = model.NewId()
-	m1.NotifyProps = model.GetDefaultChannelNotifyProps()
-	_, err := ss.Channel().SaveMember(&m1)
-	require.NoError(t, err)
-
-	m2 := model.ChannelMember{}
-	m2.ChannelId = o1.Id
-	m2.UserId = model.NewId()
-	m2.NotifyProps = model.GetDefaultChannelNotifyProps()
-	_, err = ss.Channel().SaveMember(&m2)
-	require.NoError(t, err)
-
-	m3 := model.ChannelMember{}
-	m3.ChannelId = o2.Id
-	m3.UserId = m1.UserId
-	m3.NotifyProps = model.GetDefaultChannelNotifyProps()
-	_, err = ss.Channel().SaveMember(&m3)
-	require.NoError(t, err)
-
-	m4 := model.ChannelMember{}
-	m4.ChannelId = o3.Id
-	m4.UserId = m1.UserId
-	m4.NotifyProps = model.GetDefaultChannelNotifyProps()
-	_, err = ss.Channel().SaveMember(&m4)
-	require.NoError(t, err)
-
-	list, nErr := ss.Channel().GetChannelsWithCursor(o1.TeamId, m1.UserId, &model.ChannelSearchOpts{
-		IncludeDeleted: false,
-		LastDeleteAt:   0,
-		PerPage:        model.NewInt(2),
-	}, "")
-	require.NoError(t, nErr)
-	require.Len(t, list, 2)
-	require.Equal(t, teamID, list[0].TeamId, "incorrect teamID")
-	require.Equal(t, teamID, list[1].TeamId, "incorrect teamID")
-
-	list, nErr = ss.Channel().GetChannelsWithCursor(o1.TeamId, m1.UserId, &model.ChannelSearchOpts{
-		IncludeDeleted: false,
-		LastDeleteAt:   0,
-		PerPage:        model.NewInt(2),
-	}, list[1].Id)
-	require.NoError(t, nErr)
-	require.Len(t, list, 1)
-	require.Equal(t, teamID, list[0].TeamId, "incorrect teamID")
-
-	// all channels should be returned
-	list, nErr = ss.Channel().GetChannelsWithCursor(o1.TeamId, m1.UserId, &model.ChannelSearchOpts{
-		IncludeDeleted: false,
-		LastDeleteAt:   0,
-	}, "")
-	require.NoError(t, nErr)
-	require.Len(t, list, 3)
-
-	// should return empty list
-	list, nErr = ss.Channel().GetChannelsWithCursor(o1.TeamId, m1.UserId, &model.ChannelSearchOpts{
-		IncludeDeleted: false,
-		LastDeleteAt:   0,
-	}, list[2].Id)
-	require.NoError(t, nErr)
-	require.Len(t, list, 0)
-
-	// Sleeping to guarantee that the
-	// UpdateAt is different.
-	// The proper way would be to set UpdateAt during channel creation itself,
-	// but the *Channel.PreSave method ignores any existing CreateAt value.
-	// TODO: check if using an existing CreateAt breaks anything.
-	time.Sleep(time.Millisecond)
-
-	now := model.GetMillis()
-	_, nErr = ss.Channel().Update(o1)
-	require.NoError(t, nErr)
-
-	list, nErr = ss.Channel().GetChannelsWithCursor(o1.TeamId, m1.UserId, &model.ChannelSearchOpts{
-		IncludeDeleted: false,
-		LastUpdateAt:   int(now),
-	}, "")
-	require.NoError(t, nErr)
-	// should return 1
-	require.Len(t, list, 1)
-
-	nErr = ss.Channel().Delete(o2.Id, 10)
-	require.NoError(t, nErr)
-
-	nErr = ss.Channel().Delete(o3.Id, 20)
-	require.NoError(t, nErr)
-
-	// should return 1
-	list, nErr = ss.Channel().GetChannelsWithCursor(o1.TeamId, m1.UserId, &model.ChannelSearchOpts{
-		IncludeDeleted: false,
-		LastDeleteAt:   0,
-	}, "")
-	require.NoError(t, nErr)
-	require.Len(t, list, 1)
-
-	// Should return all
-	list, nErr = ss.Channel().GetChannelsWithCursor(o1.TeamId, m1.UserId, &model.ChannelSearchOpts{
-		IncludeDeleted: true,
-		LastDeleteAt:   0,
-		PerPage:        model.NewInt(2),
-	}, "")
-	require.NoError(t, nErr)
-	require.Len(t, list, 2)
-
-	list, nErr = ss.Channel().GetChannelsWithCursor(o1.TeamId, m1.UserId, &model.ChannelSearchOpts{
-		IncludeDeleted: true,
-		LastDeleteAt:   0,
-		PerPage:        model.NewInt(2),
-	}, list[1].Id)
-	require.NoError(t, nErr)
-	require.Len(t, list, 1)
-
-	// Should still return all
-	list, nErr = ss.Channel().GetChannelsWithCursor(o1.TeamId, m1.UserId, &model.ChannelSearchOpts{
-		IncludeDeleted: true,
-		LastDeleteAt:   10,
-	}, "")
-	require.NoError(t, nErr)
-	require.Len(t, list, 3)
-
-	// Should return 2
-	list, nErr = ss.Channel().GetChannelsWithCursor(o1.TeamId, m1.UserId, &model.ChannelSearchOpts{
-		IncludeDeleted: true,
-		LastDeleteAt:   20,
-	}, "")
-	require.NoError(t, nErr)
-	require.Len(t, list, 2)
-}
-
 func testChannelStoreGetChannelsByUser(t *testing.T, ss store.Store) {
 	team := model.NewId()
 	team2 := model.NewId()
@@ -4562,183 +4403,6 @@ func testChannelStoreGetMembersForUser(t *testing.T, ss store.Store) {
 	})
 }

-func testChannelStoreGetMembersForUserWithCursor(t *testing.T, ss store.Store) {
-	t1 := model.Team{}
-	t1.DisplayName = "Team1"
-	t1.Name = NewTestId()
-	t1.Email = MakeEmail()
-	t1.Type = model.TeamOpen
-	_, err := ss.Team().Save(&t1)
-	require.NoError(t, err)
-
-	t2 := model.Team{}
-	t2.DisplayName = "Team2"
-	t2.Name = NewTestId()
-	t2.Email = MakeEmail()
-	t2.Type = model.TeamOpen
-	_, err = ss.Team().Save(&t2)
-	require.NoError(t, err)
-
-	o1 := model.Channel{}
-	o1.TeamId = t1.Id
-	o1.DisplayName = "Channel1"
-	o1.Name = NewTestId()
-	o1.Type = model.ChannelTypeOpen
-	_, nErr := ss.Channel().Save(&o1, -1)
-	require.NoError(t, nErr)
-
-	o2 := model.Channel{}
-	o2.TeamId = o1.TeamId
-	o2.DisplayName = "Channel2"
-	o2.Name = NewTestId()
-	o2.Type = model.ChannelTypeOpen
-	_, nErr = ss.Channel().Save(&o2, -1)
-	require.NoError(t, nErr)
-
-	o3 := model.Channel{}
-	o3.TeamId = t2.Id
-	o3.DisplayName = "Channel3"
-	o3.Name = NewTestId()
-	o3.Type = model.ChannelTypeOpen
-	_, nErr = ss.Channel().Save(&o3, -1)
-	require.NoError(t, nErr)
-
-	m1 := model.ChannelMember{}
-	m1.ChannelId = o1.Id
-	m1.UserId = model.NewId()
-	m1.NotifyProps = model.GetDefaultChannelNotifyProps()
-	_, err = ss.Channel().SaveMember(&m1)
-	require.NoError(t, err)
-
-	m2 := model.ChannelMember{}
-	m2.ChannelId = o2.Id
-	m2.UserId = m1.UserId
-	m2.NotifyProps = model.GetDefaultChannelNotifyProps()
-	_, err = ss.Channel().SaveMember(&m2)
-	require.NoError(t, err)
-
-	m3 := model.ChannelMember{}
-	m3.ChannelId = o3.Id
-	m3.UserId = m1.UserId
-	m3.NotifyProps = model.GetDefaultChannelNotifyProps()
-	_, err = ss.Channel().SaveMember(&m3)
-	require.NoError(t, err)
-
-	t.Run("with channels", func(t *testing.T) {
-		var members model.ChannelMembers
-		opts := &store.ChannelMemberGraphQLSearchOpts{
-			Limit: 1,
-		}
-		members, err = ss.Channel().GetMembersForUserWithCursor(m1.UserId, "", opts)
-		require.NoError(t, err)
-		assert.Len(t, members, 1)
-		opts.Limit = 3
-		members, err = ss.Channel().GetMembersForUserWithCursor(m1.UserId, "", opts)
-		require.NoError(t, err)
-		assert.Len(t, members, 3)
-		opts.AfterChannel = members[0].ChannelId
-		opts.AfterUser = m1.UserId
-		opts.Limit = 1
-		members, err = ss.Channel().GetMembersForUserWithCursor(m1.UserId, "", opts)
-		require.NoError(t, err)
-		assert.Len(t, members, 1)
-	})
-
-	t.Run("with channels and direct messages", func(t *testing.T) {
-		user := model.User{Id: m1.UserId}
-		u1 := model.User{Id: model.NewId()}
-		u2 := model.User{Id: model.NewId()}
-		u3 := model.User{Id: model.NewId()}
-		u4 := model.User{Id: model.NewId()}
-		_, nErr = ss.Channel().CreateDirectChannel(&u1, &user)
-		require.NoError(t, nErr)
-		_, nErr = ss.Channel().CreateDirectChannel(&u2, &user)
-		require.NoError(t, nErr)
-		// other user direct message
-		_, nErr = ss.Channel().CreateDirectChannel(&u3, &u4)
-		require.NoError(t, nErr)
-
-		opts := &store.ChannelMemberGraphQLSearchOpts{
-			Limit: 10,
-		}
-		members, err2 := ss.Channel().GetMembersForUserWithCursor(m1.UserId, "", opts)
-		require.NoError(t, err2)
-		assert.Len(t, members, 5)
-
-		opts.Limit = 2
-		members, err2 = ss.Channel().GetMembersForUserWithCursor(m1.UserId, "", opts)
-		require.NoError(t, err2)
-		assert.Len(t, members, 2)
-
-		opts.AfterChannel = members[1].ChannelId
-		opts.AfterUser = m1.UserId
-		opts.Limit = 2
-		members, err2 = ss.Channel().GetMembersForUserWithCursor(m1.UserId, "", opts)
-		require.NoError(t, err2)
-		assert.Len(t, members, 2)
-	})
-
-	t.Run("for a specific team", func(t *testing.T) {
-		opts := &store.ChannelMemberGraphQLSearchOpts{
-			Limit: 10,
-		}
-		members, err2 := ss.Channel().GetMembersForUserWithCursor(m1.UserId, t2.Id, opts)
-		require.NoError(t, err2)
-		assert.Len(t, members, 3)
-	})
-
-	t.Run("excluding a team", func(t *testing.T) {
-		opts := &store.ChannelMemberGraphQLSearchOpts{
-			Limit:       10,
-			ExcludeTeam: true,
-		}
-		members, err2 := ss.Channel().GetMembersForUserWithCursor(m1.UserId, t2.Id, opts)
-		require.NoError(t, err2)
-		assert.Len(t, members, 2)
-	})
-
-	t.Run("with channels, direct channels and group messages", func(t *testing.T) {
-		userIds := []string{model.NewId(), model.NewId(), model.NewId(), m1.UserId}
-		group := &model.Channel{
-			Name:        model.GetGroupNameFromUserIds(userIds),
-			DisplayName: "test",
-			Type:        model.ChannelTypeGroup,
-		}
-		var channel *model.Channel
-		channel, nErr = ss.Channel().Save(group, 10000)
-		require.NoError(t, nErr)
-		for _, userId := range userIds {
-			cm := &model.ChannelMember{
-				UserId:      userId,
-				ChannelId:   channel.Id,
-				NotifyProps: model.GetDefaultChannelNotifyProps(),
-				SchemeUser:  true,
-			}
-
-			_, err = ss.Channel().SaveMember(cm)
-			require.NoError(t, err)
-		}
-		opts := &store.ChannelMemberGraphQLSearchOpts{
-			Limit: 10,
-		}
-		members, err := ss.Channel().GetMembersForUserWithCursor(m1.UserId, "", opts)
-		require.NoError(t, err)
-		assert.Len(t, members, 6)
-
-		opts.Limit = 2
-		members, err = ss.Channel().GetMembersForUserWithCursor(m1.UserId, "", opts)
-		require.NoError(t, err)
-		assert.Len(t, members, 2)
-
-		opts.AfterChannel = members[1].ChannelId
-		opts.AfterUser = m1.UserId
-		opts.Limit = 10
-		members, err = ss.Channel().GetMembersForUserWithCursor(m1.UserId, "", opts)
-		require.NoError(t, err)
-		assert.Len(t, members, 4)
-	})
-}
-
 func testChannelStoreGetMembersForUserWithPagination(t *testing.T, ss store.Store) {
 	t1 := model.Team{
 		DisplayName: "team1",
--- a/server/channels/store/storetest/channel_store_categories.go
+++ b/server/channels/store/storetest/channel_store_categories.go
@@ -435,50 +435,6 @@ func testCreateInitialSidebarCategories(t *testing.T, ss store.Store) {
 		require.NoError(t, nErr)
 		require.Equal(t, categories, categories2)
 	})
-
-	t.Run("graphQL path to create initial favorites/channels/DMs categories on different teams", func(t *testing.T) {
-		userId := model.NewId()
-
-		t1 := &model.Team{
-			DisplayName: "DisplayName",
-			Name:        NewTestId(),
-			Email:       MakeEmail(),
-			Type:        model.TeamOpen,
-			InviteId:    model.NewId(),
-		}
-		t1, err := ss.Team().Save(t1)
-		require.NoError(t, err)
-
-		m1 := &model.TeamMember{TeamId: t1.Id, UserId: userId}
-		_, nErr := ss.Team().SaveMember(m1, -1)
-		require.NoError(t, nErr)
-
-		t2 := &model.Team{
-			DisplayName: "DisplayName2",
-			Name:        NewTestId(),
-			Email:       MakeEmail(),
-			Type:        model.TeamOpen,
-			InviteId:    model.NewId(),
-		}
-		t2, err = ss.Team().Save(t2)
-		require.NoError(t, err)
-
-		m2 := &model.TeamMember{TeamId: t2.Id, UserId: userId}
-		_, nErr = ss.Team().SaveMember(m2, -1)
-		require.NoError(t, nErr)
-
-		opts := &store.SidebarCategorySearchOpts{
-			TeamID:      t1.Id,
-			ExcludeTeam: true,
-		}
-		res, nErr := ss.Channel().CreateInitialSidebarCategories(c, userId, opts)
-		require.NoError(t, nErr)
-		require.NotEmpty(t, res)
-
-		for _, cat := range res.Categories {
-			assert.Equal(t, t2.Id, cat.TeamId)
-		}
-	})
 }

 func testCreateSidebarCategory(t *testing.T, ss store.Store) {
--- a/server/channels/store/storetest/mocks/ChannelStore.go
+++ b/server/channels/store/storetest/mocks/ChannelStore.go
@@ -976,32 +976,6 @@ func (_m *ChannelStore) GetChannelsMemberCount(channelIDs []string) (map[string]
 	return r0, r1
 }

-// GetChannelsWithCursor provides a mock function with given fields: teamId, userId, opts, afterChannelID
-func (_m *ChannelStore) GetChannelsWithCursor(teamId string, userId string, opts *model.ChannelSearchOpts, afterChannelID string) (model.ChannelList, error) {
-	ret := _m.Called(teamId, userId, opts, afterChannelID)
-
-	var r0 model.ChannelList
-	var r1 error
-	if rf, ok := ret.Get(0).(func(string, string, *model.ChannelSearchOpts, string) (model.ChannelList, error)); ok {
-		return rf(teamId, userId, opts, afterChannelID)
-	}
-	if rf, ok := ret.Get(0).(func(string, string, *model.ChannelSearchOpts, string) model.ChannelList); ok {
-		r0 = rf(teamId, userId, opts, afterChannelID)
-	} else {
-		if ret.Get(0) != nil {
-			r0 = ret.Get(0).(model.ChannelList)
-		}
-	}
-
-	if rf, ok := ret.Get(1).(func(string, string, *model.ChannelSearchOpts, string) error); ok {
-		r1 = rf(teamId, userId, opts, afterChannelID)
-	} else {
-		r1 = ret.Error(1)
-	}
-
-	return r0, r1
-}
-
 // GetChannelsWithTeamDataByIds provides a mock function with given fields: channelIds, includeDeleted
 func (_m *ChannelStore) GetChannelsWithTeamDataByIds(channelIds []string, includeDeleted bool) ([]*model.ChannelWithTeamData, error) {
 	ret := _m.Called(channelIds, includeDeleted)
@@ -1444,32 +1418,6 @@ func (_m *ChannelStore) GetMembersForUser(teamID string, userID string) (model.C
 	return r0, r1
 }

-// GetMembersForUserWithCursor provides a mock function with given fields: userID, teamID, opts
-func (_m *ChannelStore) GetMembersForUserWithCursor(userID string, teamID string, opts *store.ChannelMemberGraphQLSearchOpts) (model.ChannelMembers, error) {
-	ret := _m.Called(userID, teamID, opts)
-
-	var r0 model.ChannelMembers
-	var r1 error
-	if rf, ok := ret.Get(0).(func(string, string, *store.ChannelMemberGraphQLSearchOpts) (model.ChannelMembers, error)); ok {
-		return rf(userID, teamID, opts)
-	}
-	if rf, ok := ret.Get(0).(func(string, string, *store.ChannelMemberGraphQLSearchOpts) model.ChannelMembers); ok {
-		r0 = rf(userID, teamID, opts)
-	} else {
-		if ret.Get(0) != nil {
-			r0 = ret.Get(0).(model.ChannelMembers)
-		}
-	}
-
-	if rf, ok := ret.Get(1).(func(string, string, *store.ChannelMemberGraphQLSearchOpts) error); ok {
-		r1 = rf(userID, teamID, opts)
-	} else {
-		r1 = ret.Error(1)
-	}
-
-	return r0, r1
-}
-
 // GetMembersForUserWithPagination provides a mock function with given fields: userID, page, perPage
 func (_m *ChannelStore) GetMembersForUserWithPagination(userID string, page int, perPage int) (model.ChannelMembersWithTeamData, error) {
 	ret := _m.Called(userID, page, perPage)