From 3da77f2f058998a5e6efe9b3391823af1bb7acad Mon Sep 17 00:00:00 2001 From: mas-who <151511568+mas-who@users.noreply.github.com> Date: Fri, 15 Nov 2024 10:32:11 +0200 Subject: [PATCH] GH-29265: Fix errcheck errors in server/channels/app/platform/feature_flags.go (#29269) Co-authored-by: Ben Schumacher --- server/.golangci.yml | 1 - server/channels/app/platform/feature_flags.go | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index d9b6db9a19..699277a4bd 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -106,7 +106,6 @@ issues: channels/app/platform/busy_test.go|\ channels/app/platform/cluster_handlers.go|\ channels/app/platform/config_test.go|\ - channels/app/platform/feature_flags.go|\ channels/app/platform/helper_test.go|\ channels/app/platform/license.go|\ channels/app/platform/link_cache.go|\ diff --git a/server/channels/app/platform/feature_flags.go b/server/channels/app/platform/feature_flags.go index 0b4008d5d0..edf1042e6d 100644 --- a/server/channels/app/platform/feature_flags.go +++ b/server/channels/app/platform/feature_flags.go @@ -46,7 +46,10 @@ func (ps *PlatformService) updateFeatureFlagValuesFromManagement() { if oldFlags != newFlags { ps.logger.Debug("Feature flag change detected, updating config") *newCfg.FeatureFlags = newFlags - ps.SaveConfig(newCfg, true) + _, _, appErr := ps.SaveConfig(newCfg, true) + if appErr != nil { + ps.logger.Error("Failed to save config with updated feature flags", mlog.Err(appErr)) + } } }