From 3c9b2511bc7747d5399f3ba6935a51df13f1592d Mon Sep 17 00:00:00 2001
From: Jesse Hallam <jesse.hallam@gmail.com>
Date: Wed, 23 Apr 2025 03:37:06 -0300
Subject: [PATCH] avoid SELECT * in audit store (#30829)

---
 server/channels/store/sqlstore/audit_store.go | 24 +++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/server/channels/store/sqlstore/audit_store.go b/server/channels/store/sqlstore/audit_store.go
index da14d6d9a5..f2525132e6 100644
--- a/server/channels/store/sqlstore/audit_store.go
+++ b/server/channels/store/sqlstore/audit_store.go
@@ -13,10 +13,28 @@ import (
 
 type SqlAuditStore struct {
 	*SqlStore
+
+	auditQuery sq.SelectBuilder
 }
 
 func newSqlAuditStore(sqlStore *SqlStore) store.AuditStore {
-	return &SqlAuditStore{sqlStore}
+	s := &SqlAuditStore{
+		SqlStore: sqlStore,
+	}
+
+	s.auditQuery = s.getQueryBuilder().
+		Select(
+			"Id",
+			"CreateAt",
+			"UserId",
+			"Action",
+			"ExtraInfo",
+			"IpAddress",
+			"SessionId",
+		).
+		From("Audits")
+
+	return s
 }
 
 func (s SqlAuditStore) Save(audit *model.Audit) error {
@@ -37,9 +55,7 @@ func (s SqlAuditStore) Get(userId string, offset int, limit int) (model.Audits,
 		return nil, store.NewErrOutOfBounds(limit)
 	}
 
-	query := s.getQueryBuilder().
-		Select("*").
-		From("Audits").
+	query := s.auditQuery.
 		OrderBy("CreateAt DESC").
 		Limit(uint64(limit)).
 		Offset(uint64(offset))