Enable the errorAssertions govet check for mattermost-server code (#17346)

* Enable the errorAssertions govet check for mattermost-server code

* Removing unnecesary change

* Fixing some tests

* Fixing tests

* Fixing more after merge

* Fixing new offending entries

* Fixing small vet checks

* Fixing new cases detected by govet

* Fixing remote_cluster_test errors

* Fixing assertion

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

migrations/migrations_test.go

@@ -35,7 +35,7 @@ func TestGetMigrationState(t *testing.T) {
 		Value: "true",
 	}
 	nErr := th.App.Srv().Store.System().Save(&system)
-	assert.Nil(t, nErr)
+	assert.NoError(t, nErr)
 
 	state, job, err = GetMigrationState(migrationKey, th.App.Srv().Store)
 	assert.Nil(t, err)
@@ -43,7 +43,7 @@ func TestGetMigrationState(t *testing.T) {
 	assert.Equal(t, "completed", state)
 
 	_, nErr = th.App.Srv().Store.System().PermanentDeleteByName(migrationKey)
-	assert.Nil(t, nErr)
+	assert.NoError(t, nErr)
 
 	// Test with a job scheduled in "pending" state.
 	j1 := &model.Job{
@@ -57,7 +57,7 @@ func TestGetMigrationState(t *testing.T) {
 	}
 
 	j1, nErr = th.App.Srv().Store.Job().Save(j1)
-	require.Nil(t, nErr)
+	require.NoError(t, nErr)
 
 	state, job, err = GetMigrationState(migrationKey, th.App.Srv().Store)
 	assert.Nil(t, err)
@@ -76,7 +76,7 @@ func TestGetMigrationState(t *testing.T) {
 	}
 
 	j2, nErr = th.App.Srv().Store.Job().Save(j2)
-	require.Nil(t, nErr)
+	require.NoError(t, nErr)
 
 	state, job, err = GetMigrationState(migrationKey, th.App.Srv().Store)
 	assert.Nil(t, err)
@@ -95,7 +95,7 @@ func TestGetMigrationState(t *testing.T) {
 	}
 
 	j3, nErr = th.App.Srv().Store.Job().Save(j3)
-	require.Nil(t, nErr)
+	require.NoError(t, nErr)
 
 	state, job, err = GetMigrationState(migrationKey, th.App.Srv().Store)
 	assert.Nil(t, err)