Enable the errorAssertions govet check for mattermost-server code (#17346)

* Enable the errorAssertions govet check for mattermost-server code

* Removing unnecesary change

* Fixing some tests

* Fixing tests

* Fixing more after merge

* Fixing new offending entries

* Fixing small vet checks

* Fixing new cases detected by govet

* Fixing remote_cluster_test errors

* Fixing assertion

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

config/database_test.go

@@ -82,7 +82,7 @@ func getActualDatabaseConfig(t *testing.T) (string, *model.Config) {
 
 		var actualCfg *model.Config
 		err = json.Unmarshal(actual.Value, &actualCfg)
-		require.Nil(t, err)
+		require.NoError(t, err)
 		return actual.ID, actualCfg
 	}
 	var actual struct {
@@ -95,7 +95,7 @@ func getActualDatabaseConfig(t *testing.T) (string, *model.Config) {
 
 	var actualCfg *model.Config
 	err = json.Unmarshal(actual.Value, &actualCfg)
-	require.Nil(t, err)
+	require.NoError(t, err)
 	return actual.ID, actualCfg
 }
 

config/file_test.go

@@ -54,12 +54,12 @@ func getActualFileConfig(t *testing.T, path string) *model.Config {
 	t.Helper()
 
 	f, err := os.Open(path)
-	require.Nil(t, err)
+	require.NoError(t, err)
 	defer f.Close()
 
 	var actualCfg *model.Config
 	err = json.NewDecoder(f).Decode(&actualCfg)
-	require.Nil(t, err)
+	require.NoError(t, err)
 
 	return actualCfg
 }