From 2e4373f91c01e085345cfc7d56bd1faeb1bb33d8 Mon Sep 17 00:00:00 2001 From: Christopher Speller Date: Wed, 28 Nov 2018 06:43:22 -0800 Subject: [PATCH] Properly reuturning result from store function so failure is caught. (#9890) --- store/sqlstore/preference_store.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/store/sqlstore/preference_store.go b/store/sqlstore/preference_store.go index bfe5f66139..5790f951ca 100644 --- a/store/sqlstore/preference_store.go +++ b/store/sqlstore/preference_store.go @@ -128,9 +128,9 @@ func (s SqlPreferenceStore) save(transaction *gorp.Transaction, preference *mode } if count == 1 { - s.update(transaction, preference) + result = s.update(transaction, preference) } else { - s.insert(transaction, preference) + result = s.insert(transaction, preference) } } else { result.Err = model.NewAppError("SqlPreferenceStore.save", "store.sql_preference.save.missing_driver.app_error", nil, "Failed to update preference because of missing driver", http.StatusNotImplemented)