diff --git a/e2e-tests/cypress/tests/integration/channels/accessibility/accessibility_buttons_spec.js b/e2e-tests/cypress/tests/integration/channels/accessibility/accessibility_buttons_spec.js index 9833aa5eab..c1529b095f 100644 --- a/e2e-tests/cypress/tests/integration/channels/accessibility/accessibility_buttons_spec.js +++ b/e2e-tests/cypress/tests/integration/channels/accessibility/accessibility_buttons_spec.js @@ -35,11 +35,7 @@ describe('Verify Accessibility Support in different Buttons', () => { within(() => { // * Verify accessibility support in Sidebar Expand and Shrink icon cy.get('button.sidebar--right__expand'). - should('have.attr', 'aria-label', 'Expand'). - within(() => { - cy.get('.icon-arrow-expand').should('have.attr', 'aria-label', 'Expand Sidebar Icon'); - cy.get('.icon-arrow-collapse').should('have.attr', 'aria-label', 'Collapse Sidebar Icon'); - }); + should('have.attr', 'aria-label', 'Expand Sidebar Icon'); // * Verify accessibility support in Close icon cy.get('#rhsCloseButton'). diff --git a/e2e-tests/cypress/tests/support/ui/sidebar_right.js b/e2e-tests/cypress/tests/support/ui/sidebar_right.js index 599e8d8af2..fea51b6d1e 100644 --- a/e2e-tests/cypress/tests/support/ui/sidebar_right.js +++ b/e2e-tests/cypress/tests/support/ui/sidebar_right.js @@ -19,7 +19,7 @@ Cypress.Commands.add('uiCloseRHS', () => { }); Cypress.Commands.add('uiExpandRHS', () => { - cy.findByLabelText('Expand').click(); + cy.findByLabelText('Expand Sidebar Icon').click(); }); Cypress.Commands.add('isExpanded', {prevSubject: true}, (subject) => { diff --git a/webapp/channels/src/components/rhs_card_header/rhs_card_header.tsx b/webapp/channels/src/components/rhs_card_header/rhs_card_header.tsx index f05ad1f555..6a93b0c042 100644 --- a/webapp/channels/src/components/rhs_card_header/rhs_card_header.tsx +++ b/webapp/channels/src/components/rhs_card_header/rhs_card_header.tsx @@ -130,6 +130,9 @@ class RhsCardHeader extends React.PureComponent { ); } + const collapseIconLabel = this.props.intl.formatMessage({id: 'rhs_header.collapseSidebarTooltip.icon', defaultMessage: 'Collapse Sidebar Icon'}); + const expandIconLabel = this.props.intl.formatMessage({id: 'rhs_header.expandSidebarTooltip.icon', defaultMessage: 'Expand Sidebar Icon'}); + return (
@@ -146,16 +149,14 @@ class RhsCardHeader extends React.PureComponent { diff --git a/webapp/channels/src/components/rhs_header_post/rhs_header_post.tsx b/webapp/channels/src/components/rhs_header_post/rhs_header_post.tsx index ebfb93d5cf..704b1da407 100644 --- a/webapp/channels/src/components/rhs_header_post/rhs_header_post.tsx +++ b/webapp/channels/src/components/rhs_header_post/rhs_header_post.tsx @@ -162,6 +162,9 @@ class RhsHeaderPost extends React.PureComponent { ); } + const collapseIconLabel = formatMessage({id: 'rhs_header.collapseSidebarTooltip.icon', defaultMessage: 'Collapse Sidebar Icon'}); + const expandIconLabel = formatMessage({id: 'rhs_header.expandSidebarTooltip.icon', defaultMessage: 'Expand Sidebar Icon'}); + return (
@@ -194,16 +197,14 @@ class RhsHeaderPost extends React.PureComponent {