MM-15288: Migrate CommandStore.Get to sync by default (#10739)

* MM-15288: Migrate Command.Get to sync by default

* addressing review comments, updating status code of err returned by Get Method
Этот коммит содержится в:
Puneeth Reddy
2019-05-06 09:12:41 -07:00
коммит произвёл Jesús Espino
родитель fc15eda37f
Коммит 2d3fb4f426
7 изменённых файлов: 50 добавлений и 47 удалений

Просмотреть файл

@@ -61,16 +61,14 @@ func (s SqlCommandStore) Save(command *model.Command) (*model.Command, *model.Ap
return command, nil
}
func (s SqlCommandStore) Get(id string) store.StoreChannel {
return store.Do(func(result *store.StoreResult) {
var command model.Command
func (s SqlCommandStore) Get(id string) (*model.Command, *model.AppError) {
var command model.Command
if err := s.GetReplica().SelectOne(&command, "SELECT * FROM Commands WHERE Id = :Id AND DeleteAt = 0", map[string]interface{}{"Id": id}); err != nil {
result.Err = model.NewAppError("SqlCommandStore.Get", "store.sql_command.save.get.app_error", nil, "id="+id+", err="+err.Error(), http.StatusInternalServerError)
}
if err := s.GetReplica().SelectOne(&command, "SELECT * FROM Commands WHERE Id = :Id AND DeleteAt = 0", map[string]interface{}{"Id": id}); err != nil {
return nil, model.NewAppError("SqlCommandStore.Get", "store.sql_command.save.get.app_error", nil, "id="+id+", err="+err.Error(), http.StatusInternalServerError)
}
result.Data = &command
})
return &command, nil
}
func (s SqlCommandStore) GetByTeam(teamId string) ([]*model.Command, *model.AppError) {