Working on refactoring jobs service (#19205)

* Working on refactoring jobs service

* Making more consistent with the previous existing code

* Remove no longer needed functions

* Making a base PeridicScheduler to use it in most of the schedulers implementations

* Removing accidental complexity from on of the jobs

* Removing accidental complexity from expirynotify

* Fixing compilation from previous commit

* Remove accidental complexity from the export_delete job

* Simplifying the workers by making a reusable worker

* Using simple worker for export_delete job

* Simpliying export process job

* Simpliying extract content job

* Simpliying import delete job

* Simpliying import process job

* Simpliying product noticies job

* Simpliying fix crt channel unreads job (only removing the uneeded register function)

* Simpliying migrations job (only removing the uneeded register function)

* fixup

* Simpliying plugins job (only removing the uneeded register function)

* Simpliying bleve indexing job (only removing the uneeded register function)

* Simpliying resend invitation email job (only removing the uneeded register function)

* Fixing tests

* Simplifying migration tests infrastructure

* Adding missed license to files

* Adding an empty file to imports package to ensure this package exist even without enterprise repo

* Regenerating einterfaces mocks

* Adding missed license to files

* Updating i18n/en.json file

* help fixing enterprise tests compilation

* Adding new DailyScheduler

* Fixing typo and changing the waitTime type for periodic sechduler

* Making the daily scheduler more generic

* Adding comments to clarify not used parameters in interface scheduler interface implementations

* Using merror to handle multiple errors in jobs workers

* Fixing linter errors

* Addressing PR review comments

* Reverting go.tools.mod changes

* Removing the static check for worker type in the model (moving it to the insertion of new jobs

* Moving migrations job to the jobs directory

* Fixing (and improving a bit) tests

* Apply suggestions from code review

Co-authored-by: Doug Lauder <wiggin77@warpmail.net>

* Fixing enterprise tests

* Removing unneeded InitWorkers/InitSchedulers calls

* Fix expirenotify job when error happens

* Fixing govet errors

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>

api4/apitestlib.go

@@ -189,8 +189,6 @@ func setupTestHelper(dbStore store.Store, searchEngine *searchengine.Broker, ent
 
 	if enterprise {
 		th.App.Srv().SetLicense(model.NewTestLicense())
-		th.App.Srv().Jobs.InitWorkers()
-		th.App.Srv().Jobs.InitSchedulers()
 	} else {
 		th.App.Srv().SetLicense(nil)
 	}

api4/job_test.go

@@ -19,33 +19,29 @@ func TestCreateJob(t *testing.T) {
 	defer th.TearDown()
 
 	job := &model.Job{
-		Type: model.JobTypeMessageExport,
+		Type: model.JobTypeActiveUsers,
 		Data: map[string]string{
 			"thing": "stuff",
 		},
 	}
 
-	_, resp, err := th.SystemManagerClient.CreateJob(job)
-	require.Error(t, err)
-	CheckForbiddenStatus(t, resp)
+	t.Run("valid job as user without permissions", func(t *testing.T) {
+		_, resp, err := th.SystemManagerClient.CreateJob(job)
+		require.Error(t, err)
+		CheckForbiddenStatus(t, resp)
+	})
 
-	received, _, err := th.SystemAdminClient.CreateJob(job)
-	require.NoError(t, err)
+	t.Run("valid job as user with permissions", func(t *testing.T) {
+		received, _, err := th.SystemAdminClient.CreateJob(job)
+		require.NoError(t, err)
+		defer th.App.Srv().Store.Job().Delete(received.Id)
+	})
 
-	defer th.App.Srv().Store.Job().Delete(received.Id)
-
-	job = &model.Job{
-		Type: model.NewId(),
-	}
-
-	_, resp, err = th.SystemAdminClient.CreateJob(job)
-	require.Error(t, err)
-	CheckBadRequestStatus(t, resp)
-
-	job.Type = model.JobTypeElasticsearchPostIndexing
-	_, resp, err = th.Client.CreateJob(job)
-	require.Error(t, err)
-	CheckForbiddenStatus(t, resp)
+	t.Run("invalid job type as user without permissions", func(t *testing.T) {
+		_, resp, err := th.SystemAdminClient.CreateJob(&model.Job{Type: model.NewId()})
+		require.Error(t, err)
+		CheckBadRequestStatus(t, resp)
+	})
 }
 
 func TestGetJob(t *testing.T) {