[MM-21119] Update config files permissions (#13386)

* Update config files permissions

* Add error check

* Update permissions for persist

config/file.go

@@ -122,7 +122,7 @@ func (fs *FileStore) persist(cfg *model.Config) error {
 		return errors.Wrap(err, "failed to serialize")
 	}
 
-	err = ioutil.WriteFile(fs.path, b, 0644)
+	err = ioutil.WriteFile(fs.path, b, 0600)
 	if err != nil {
 		return errors.Wrap(err, "failed to write file")
 	}
@@ -184,7 +184,7 @@ func (fs *FileStore) GetFile(name string) ([]byte, error) {
 func (fs *FileStore) SetFile(name string, data []byte) error {
 	resolvedPath := fs.resolveFilePath(name)
 
-	err := ioutil.WriteFile(resolvedPath, data, 0777)
+	err := ioutil.WriteFile(resolvedPath, data, 0600)
 	if err != nil {
 		return errors.Wrapf(err, "failed to write file to %s", resolvedPath)
 	}

config/file_test.go

@@ -924,6 +924,14 @@ func TestFileSetFile(t *testing.T) {
 		require.Equal(t, []byte("new file"), data)
 	})
 
+	t.Run("should set right permissions", func(t *testing.T) {
+		absolutePath := filepath.Join(filepath.Dir(path), "new")
+		err := fs.SetFile(absolutePath, []byte("data"))
+		require.NoError(t, err)
+		fi, err := os.Stat(absolutePath)
+		require.NoError(t, err)
+		require.Equal(t, os.FileMode(0600), fi.Mode().Perm())
+	})
 }
 
 func TestFileHasFile(t *testing.T) {