mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность

[MM-60619] Annotate cluster logs messages (#28268)

Просмотр исходного кода
Этот коммит содержится в:
Ben Schumacher
2024-09-27 09:17:16 +02:00
коммит произвёл GitHub
родитель bd61f1484b
Коммит 2b426573cd
9 изменённых файлов: 82 добавлений и 76 удалений
Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

14
server/channels/api4/system.go
Просмотреть файл

@@ -378,9 +378,9 @@ func queryLogs(c *Context, w http.ResponseWriter, r *http.Request) {
return return
} }
logs, logerr := c.App.QueryLogs(c.AppContext, c.Params.Page, c.Params.LogsPerPage, logFilter) logs, appErr := c.App.QueryLogs(c.AppContext, c.Params.Page, c.Params.LogsPerPage, logFilter)
if logerr != nil { if appErr != nil {
c.Err = logerr c.Err = appErr
return return
} }
@@ -388,11 +388,11 @@ func queryLogs(c *Context, w http.ResponseWriter, r *http.Request) {
var result interface{} var result interface{}
for node, logLines := range logs { for node, logLines := range logs {
for _, log := range logLines { for _, log := range logLines {
err2 := json.Unmarshal([]byte(log), &result) err = json.Unmarshal([]byte(log), &result)
if err2 == nil { if err != nil {
logsJSON[node] = append(logsJSON[node], result) c.Logger.Warn("Error parsing log line in Server Logs", mlog.String("from_node", node), mlog.Err(err))
} else { } else {
c.Logger.Warn("Error parsing log line in Server Logs") logsJSON[node] = append(logsJSON[node], result)
} }
} }
} }

28
server/channels/app/admin.go
Просмотреть файл

@@ -21,7 +21,7 @@ var latestVersionCache = cache.NewLRU(&cache.CacheOptions{
Size: 1, Size: 1,
}) })
func (s *Server) GetLogs(c request.CTX, page, perPage int) ([]string, *model.AppError) { func (s *Server) GetLogs(rctx request.CTX, page, perPage int) ([]string, *model.AppError) {
var lines []string var lines []string
license := s.License() license := s.License()
@@ -33,11 +33,11 @@ func (s *Server) GetLogs(c request.CTX, page, perPage int) ([]string, *model.App
lines = append(lines, "-----------------------------------------------------------------------------------------------------------") lines = append(lines, "-----------------------------------------------------------------------------------------------------------")
lines = append(lines, "-----------------------------------------------------------------------------------------------------------") lines = append(lines, "-----------------------------------------------------------------------------------------------------------")
} else { } else {
c.Logger().Error("Could not get cluster info") rctx.Logger().Error("Could not get cluster info")
} }
} }
melines, err := s.GetLogsSkipSend(page, perPage, &model.LogFilter{}) melines, err := s.GetLogsSkipSend(rctx, page, perPage, &model.LogFilter{})
if err != nil { if err != nil {
return nil, err return nil, err
} }
@@ -45,7 +45,7 @@ func (s *Server) GetLogs(c request.CTX, page, perPage int) ([]string, *model.App
lines = append(lines, melines...) lines = append(lines, melines...)
if s.platform.Cluster() != nil && *s.platform.Config().ClusterSettings.Enable { if s.platform.Cluster() != nil && *s.platform.Config().ClusterSettings.Enable {
clines, err := s.platform.Cluster().GetLogs(page, perPage) clines, err := s.platform.Cluster().GetLogs(rctx, page, perPage)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@@ -56,7 +56,7 @@ func (s *Server) GetLogs(c request.CTX, page, perPage int) ([]string, *model.App
return lines, nil return lines, nil
} }
func (s *Server) QueryLogs(c request.CTX, page, perPage int, logFilter *model.LogFilter) (map[string][]string, *model.AppError) { func (s *Server) QueryLogs(rctx request.CTX, page, perPage int, logFilter *model.LogFilter) (map[string][]string, *model.AppError) {
logData := make(map[string][]string) logData := make(map[string][]string)
serverName := "default" serverName := "default"
@@ -66,7 +66,7 @@ func (s *Server) QueryLogs(c request.CTX, page, perPage int, logFilter *model.Lo
if info := s.platform.Cluster().GetMyClusterInfo(); info != nil { if info := s.platform.Cluster().GetMyClusterInfo(); info != nil {
serverName = info.Hostname serverName = info.Hostname
} else { } else {
c.Logger().Error("Could not get cluster info") rctx.Logger().Error("Could not get cluster info")
} }
} }
@@ -74,15 +74,15 @@ func (s *Server) QueryLogs(c request.CTX, page, perPage int, logFilter *model.Lo
if len(serverNames) > 0 { if len(serverNames) > 0 {
for _, nodeName := range serverNames { for _, nodeName := range serverNames {
if nodeName == "default" { if nodeName == "default" {
AddLocalLogs(logData, s, page, perPage, nodeName, logFilter) AddLocalLogs(rctx, logData, s, page, perPage, nodeName, logFilter)
} }
} }
} else { } else {
AddLocalLogs(logData, s, page, perPage, serverName, logFilter) AddLocalLogs(rctx, logData, s, page, perPage, serverName, logFilter)
} }
if s.platform.Cluster() != nil && *s.Config().ClusterSettings.Enable { if s.platform.Cluster() != nil && *s.Config().ClusterSettings.Enable {
clusterLogs, err := s.platform.Cluster().QueryLogs(page, perPage) clusterLogs, err := s.platform.Cluster().QueryLogs(rctx, page, perPage)
if err != nil { if err != nil {
return nil, err return nil, err
} }
@@ -101,8 +101,8 @@ func (s *Server) QueryLogs(c request.CTX, page, perPage int, logFilter *model.Lo
return logData, nil return logData, nil
} }
func AddLocalLogs(logData map[string][]string, s *Server, page, perPage int, serverName string, logFilter *model.LogFilter) *model.AppError { func AddLocalLogs(rctx request.CTX, logData map[string][]string, s *Server, page, perPage int, serverName string, logFilter *model.LogFilter) *model.AppError {
currentServerLogs, err := s.GetLogsSkipSend(page, perPage, logFilter) currentServerLogs, err := s.GetLogsSkipSend(rctx, page, perPage, logFilter)
if err != nil { if err != nil {
return err return err
} }
@@ -119,12 +119,12 @@ func (a *App) GetLogs(rctx request.CTX, page, perPage int) ([]string, *model.App
return a.Srv().GetLogs(rctx, page, perPage) return a.Srv().GetLogs(rctx, page, perPage)
} }
func (s *Server) GetLogsSkipSend(page, perPage int, logFilter *model.LogFilter) ([]string, *model.AppError) { func (s *Server) GetLogsSkipSend(rctx request.CTX, page, perPage int, logFilter *model.LogFilter) ([]string, *model.AppError) {
return s.platform.GetLogsSkipSend(page, perPage, logFilter) return s.platform.GetLogsSkipSend(rctx, page, perPage, logFilter)
} }
func (a *App) GetLogsSkipSend(rctx request.CTX, page, perPage int, logFilter *model.LogFilter) ([]string, *model.AppError) { func (a *App) GetLogsSkipSend(rctx request.CTX, page, perPage int, logFilter *model.LogFilter) ([]string, *model.AppError) {
return a.Srv().GetLogsSkipSend(page, perPage, logFilter) return a.Srv().GetLogsSkipSend(rctx, page, perPage, logFilter)
} }
func (a *App) GetClusterStatus(rctx request.CTX) []*model.ClusterInfo { func (a *App) GetClusterStatus(rctx request.CTX) []*model.ClusterInfo {

2
server/channels/app/analytics.go
Просмотреть файл

@@ -157,7 +157,7 @@ func (a *App) getAnalytics(rctx request.CTX, name string, teamID string, forSupp
// If in HA mode then aggregate all the stats // If in HA mode then aggregate all the stats
if a.Cluster() != nil && *a.Config().ClusterSettings.Enable { if a.Cluster() != nil && *a.Config().ClusterSettings.Enable {
stats, err2 := a.Cluster().GetClusterStats() stats, err2 := a.Cluster().GetClusterStats(rctx)
if err2 != nil { if err2 != nil {
return nil, err2 return nil, err2
} }

18
server/channels/app/busy_test.go
Просмотреть файл

@@ -135,16 +135,18 @@ func (c *ClusterMock) StartInterNodeCommunication() {}
func (c *ClusterMock) StopInterNodeCommunication() {} func (c *ClusterMock) StopInterNodeCommunication() {}
func (c *ClusterMock) RegisterClusterMessageHandler(event model.ClusterEvent, crm einterfaces.ClusterMessageHandler) { func (c *ClusterMock) RegisterClusterMessageHandler(event model.ClusterEvent, crm einterfaces.ClusterMessageHandler) {
} }
func (c *ClusterMock) GetClusterId() string { return "cluster_mock" } func (c *ClusterMock) GetClusterId() string { return "cluster_mock" }
func (c *ClusterMock) IsLeader() bool { return false } func (c *ClusterMock) IsLeader() bool { return false }
func (c *ClusterMock) GetMyClusterInfo() *model.ClusterInfo { return nil } func (c *ClusterMock) GetMyClusterInfo() *model.ClusterInfo { return nil }
func (c *ClusterMock) GetClusterInfos() []*model.ClusterInfo { return nil } func (c *ClusterMock) GetClusterInfos() []*model.ClusterInfo { return nil }
func (c *ClusterMock) NotifyMsg(buf []byte) {} func (c *ClusterMock) NotifyMsg(buf []byte) {}
func (c *ClusterMock) GetClusterStats() ([]*model.ClusterStats, *model.AppError) { return nil, nil } func (c *ClusterMock) GetClusterStats(rctx request.CTX) ([]*model.ClusterStats, *model.AppError) {
func (c *ClusterMock) GetLogs(page, perPage int) ([]string, *model.AppError) {
return nil, nil return nil, nil
} }
func (c *ClusterMock) QueryLogs(page, perPage int) (map[string][]string, *model.AppError) { func (c *ClusterMock) GetLogs(rctx request.CTX, page, perPage int) ([]string, *model.AppError) {
return nil, nil
}
func (c *ClusterMock) QueryLogs(rctx request.CTX, page, perPage int) (map[string][]string, *model.AppError) {
return nil, nil return nil, nil
} }
func (c *ClusterMock) GenerateSupportPacket(rctx request.CTX, options *model.SupportPacketOptions) (map[string][]model.FileData, error) { func (c *ClusterMock) GenerateSupportPacket(rctx request.CTX, options *model.SupportPacketOptions) (map[string][]model.FileData, error) {

20
server/channels/app/platform/busy_test.go
Просмотреть файл

@@ -135,14 +135,18 @@ func (c *ClusterMock) StartInterNodeCommunication() {}
func (c *ClusterMock) StopInterNodeCommunication() {} func (c *ClusterMock) StopInterNodeCommunication() {}
func (c *ClusterMock) RegisterClusterMessageHandler(event model.ClusterEvent, crm einterfaces.ClusterMessageHandler) { func (c *ClusterMock) RegisterClusterMessageHandler(event model.ClusterEvent, crm einterfaces.ClusterMessageHandler) {
} }
func (c *ClusterMock) GetClusterId() string { return "cluster_mock" } func (c *ClusterMock) GetClusterId() string { return "cluster_mock" }
func (c *ClusterMock) IsLeader() bool { return false } func (c *ClusterMock) IsLeader() bool { return false }
func (c *ClusterMock) GetMyClusterInfo() *model.ClusterInfo { return nil } func (c *ClusterMock) GetMyClusterInfo() *model.ClusterInfo { return nil }
func (c *ClusterMock) GetClusterInfos() []*model.ClusterInfo { return nil } func (c *ClusterMock) GetClusterInfos() []*model.ClusterInfo { return nil }
func (c *ClusterMock) NotifyMsg(buf []byte) {} func (c *ClusterMock) NotifyMsg(buf []byte) {}
func (c *ClusterMock) GetClusterStats() ([]*model.ClusterStats, *model.AppError) { return nil, nil } func (c *ClusterMock) GetClusterStats(rctx request.CTX) ([]*model.ClusterStats, *model.AppError) {
func (c *ClusterMock) GetLogs(page, perPage int) ([]string, *model.AppError) { return nil, nil } return nil, nil
func (c *ClusterMock) QueryLogs(page, perPage int) (map[string][]string, *model.AppError) { }
func (c *ClusterMock) GetLogs(rctx request.CTX, page, perPage int) ([]string, *model.AppError) {
return nil, nil
}
func (c *ClusterMock) QueryLogs(rctx request.CTX, page, perPage int) (map[string][]string, *model.AppError) {
return nil, nil return nil, nil
} }
func (c *ClusterMock) GenerateSupportPacket(rctx request.CTX, options *model.SupportPacketOptions) (map[string][]model.FileData, error) { func (c *ClusterMock) GenerateSupportPacket(rctx request.CTX, options *model.SupportPacketOptions) (map[string][]model.FileData, error) {

10
server/channels/app/platform/log.go
Просмотреть файл

@@ -121,7 +121,7 @@ func (ps *PlatformService) RemoveUnlicensedLogTargets(license *model.License) {
}) })
} }
func (ps *PlatformService) GetLogsSkipSend(page, perPage int, logFilter *model.LogFilter) ([]string, *model.AppError) { func (ps *PlatformService) GetLogsSkipSend(rctx request.CTX, page, perPage int, logFilter *model.LogFilter) ([]string, *model.AppError) {
var lines []string var lines []string
if *ps.Config().LogSettings.EnableFile { if *ps.Config().LogSettings.EnableFile {
@@ -175,10 +175,10 @@ func (ps *PlatformService) GetLogsSkipSend(page, perPage int, logFilter *model.L
var entry *model.LogEntry var entry *model.LogEntry
err = json.Unmarshal(line, &entry) err = json.Unmarshal(line, &entry)
if err != nil { if err != nil {
mlog.Debug("Failed to parse line, skipping") rctx.Logger().Debug("Failed to parse line, skipping")
} else { } else {
filtered = isLogFilteredByLevel(logFilter, entry) || filtered filtered = isLogFilteredByLevel(logFilter, entry) || filtered
filtered = isLogFilteredByDate(logFilter, entry) || filtered filtered = isLogFilteredByDate(rctx, logFilter, entry) || filtered
} }
if filtered { if filtered {
@@ -257,7 +257,7 @@ func isLogFilteredByLevel(logFilter *model.LogFilter, entry *model.LogEntry) boo
return true return true
} }
func isLogFilteredByDate(logFilter *model.LogFilter, entry *model.LogEntry) bool { func isLogFilteredByDate(rctx request.CTX, logFilter *model.LogFilter, entry *model.LogEntry) bool {
if logFilter.DateFrom == "" && logFilter.DateTo == "" { if logFilter.DateFrom == "" && logFilter.DateTo == "" {
return false return false
} }
@@ -273,7 +273,7 @@ func isLogFilteredByDate(logFilter *model.LogFilter, entry *model.LogEntry) bool
timestamp, err := time.Parse("2006-01-02 15:04:05.999 -07:00", entry.Timestamp) timestamp, err := time.Parse("2006-01-02 15:04:05.999 -07:00", entry.Timestamp)
if err != nil { if err != nil {
mlog.Debug("Cannot parse timestamp, skipping") rctx.Logger().Debug("Cannot parse timestamp, skipping")
return false return false
} }

6
server/channels/testlib/cluster.go
Просмотреть файл

@@ -52,15 +52,15 @@ func (c *FakeClusterInterface) SendClusterMessageToNode(nodeID string, message *
func (c *FakeClusterInterface) NotifyMsg(buf []byte) {} func (c *FakeClusterInterface) NotifyMsg(buf []byte) {}
func (c *FakeClusterInterface) GetClusterStats() ([]*model.ClusterStats, *model.AppError) { func (c *FakeClusterInterface) GetClusterStats(rctx request.CTX) ([]*model.ClusterStats, *model.AppError) {
return nil, nil return nil, nil
} }
func (c *FakeClusterInterface) GetLogs(page, perPage int) ([]string, *model.AppError) { func (c *FakeClusterInterface) GetLogs(rctx request.CTX, page, perPage int) ([]string, *model.AppError) {
return []string{}, nil return []string{}, nil
} }
func (c *FakeClusterInterface) QueryLogs(page, perPage int) (map[string][]string, *model.AppError) { func (c *FakeClusterInterface) QueryLogs(rctx request.CTX, page, perPage int) (map[string][]string, *model.AppError) {
return make(map[string][]string), nil return make(map[string][]string), nil
} }

6
server/einterfaces/cluster.go
Просмотреть файл

@@ -25,9 +25,9 @@ type ClusterInterface interface {
SendClusterMessage(msg *model.ClusterMessage) SendClusterMessage(msg *model.ClusterMessage)
SendClusterMessageToNode(nodeID string, msg *model.ClusterMessage) error SendClusterMessageToNode(nodeID string, msg *model.ClusterMessage) error
NotifyMsg(buf []byte) NotifyMsg(buf []byte)
GetClusterStats() ([]*model.ClusterStats, *model.AppError) GetClusterStats(rctx request.CTX) ([]*model.ClusterStats, *model.AppError)
GetLogs(page, perPage int) ([]string, *model.AppError) GetLogs(ctx request.CTX, page, perPage int) ([]string, *model.AppError)
QueryLogs(page, perPage int) (map[string][]string, *model.AppError) QueryLogs(rctx request.CTX, page, perPage int) (map[string][]string, *model.AppError)
GenerateSupportPacket(rctx request.CTX, options *model.SupportPacketOptions) (map[string][]model.FileData, error) GenerateSupportPacket(rctx request.CTX, options *model.SupportPacketOptions) (map[string][]model.FileData, error)
GetPluginStatuses() (model.PluginStatuses, *model.AppError) GetPluginStatuses() (model.PluginStatuses, *model.AppError)
ConfigChanged(previousConfig *model.Config, newConfig *model.Config, sendToOtherServer bool) *model.AppError ConfigChanged(previousConfig *model.Config, newConfig *model.Config, sendToOtherServer bool) *model.AppError

54
server/einterfaces/mocks/ClusterInterface.go
Просмотреть файл

@@ -106,9 +106,9 @@ func (_m *ClusterInterface) GetClusterInfos() []*model.ClusterInfo {
return r0 return r0
} }
// GetClusterStats provides a mock function with given fields: // GetClusterStats provides a mock function with given fields: rctx
func (_m *ClusterInterface) GetClusterStats() ([]*model.ClusterStats, *model.AppError) { func (_m *ClusterInterface) GetClusterStats(rctx request.CTX) ([]*model.ClusterStats, *model.AppError) {
ret := _m.Called() ret := _m.Called(rctx)
if len(ret) == 0 { if len(ret) == 0 {
panic("no return value specified for GetClusterStats") panic("no return value specified for GetClusterStats")
@@ -116,19 +116,19 @@ func (_m *ClusterInterface) GetClusterStats() ([]*model.ClusterStats, *model.App
var r0 []*model.ClusterStats var r0 []*model.ClusterStats
var r1 *model.AppError var r1 *model.AppError
if rf, ok := ret.Get(0).(func() ([]*model.ClusterStats, *model.AppError)); ok { if rf, ok := ret.Get(0).(func(request.CTX) ([]*model.ClusterStats, *model.AppError)); ok {
return rf() return rf(rctx)
} }
if rf, ok := ret.Get(0).(func() []*model.ClusterStats); ok { if rf, ok := ret.Get(0).(func(request.CTX) []*model.ClusterStats); ok {
r0 = rf() r0 = rf(rctx)
} else { } else {
if ret.Get(0) != nil { if ret.Get(0) != nil {
r0 = ret.Get(0).([]*model.ClusterStats) r0 = ret.Get(0).([]*model.ClusterStats)
} }
} }
if rf, ok := ret.Get(1).(func() *model.AppError); ok { if rf, ok := ret.Get(1).(func(request.CTX) *model.AppError); ok {
r1 = rf() r1 = rf(rctx)
} else { } else {
if ret.Get(1) != nil { if ret.Get(1) != nil {
r1 = ret.Get(1).(*model.AppError) r1 = ret.Get(1).(*model.AppError)
@@ -138,9 +138,9 @@ func (_m *ClusterInterface) GetClusterStats() ([]*model.ClusterStats, *model.App
return r0, r1 return r0, r1
} }
// GetLogs provides a mock function with given fields: page, perPage // GetLogs provides a mock function with given fields: ctx, page, perPage
func (_m *ClusterInterface) GetLogs(page int, perPage int) ([]string, *model.AppError) { func (_m *ClusterInterface) GetLogs(ctx request.CTX, page int, perPage int) ([]string, *model.AppError) {
ret := _m.Called(page, perPage) ret := _m.Called(ctx, page, perPage)
if len(ret) == 0 { if len(ret) == 0 {
panic("no return value specified for GetLogs") panic("no return value specified for GetLogs")
@@ -148,19 +148,19 @@ func (_m *ClusterInterface) GetLogs(page int, perPage int) ([]string, *model.App
var r0 []string var r0 []string
var r1 *model.AppError var r1 *model.AppError
if rf, ok := ret.Get(0).(func(int, int) ([]string, *model.AppError)); ok { if rf, ok := ret.Get(0).(func(request.CTX, int, int) ([]string, *model.AppError)); ok {
return rf(page, perPage) return rf(ctx, page, perPage)
} }
if rf, ok := ret.Get(0).(func(int, int) []string); ok { if rf, ok := ret.Get(0).(func(request.CTX, int, int) []string); ok {
r0 = rf(page, perPage) r0 = rf(ctx, page, perPage)
} else { } else {
if ret.Get(0) != nil { if ret.Get(0) != nil {
r0 = ret.Get(0).([]string) r0 = ret.Get(0).([]string)
} }
} }
if rf, ok := ret.Get(1).(func(int, int) *model.AppError); ok { if rf, ok := ret.Get(1).(func(request.CTX, int, int) *model.AppError); ok {
r1 = rf(page, perPage) r1 = rf(ctx, page, perPage)
} else { } else {
if ret.Get(1) != nil { if ret.Get(1) != nil {
r1 = ret.Get(1).(*model.AppError) r1 = ret.Get(1).(*model.AppError)
@@ -263,9 +263,9 @@ func (_m *ClusterInterface) NotifyMsg(buf []byte) {
_m.Called(buf) _m.Called(buf)
} }
// QueryLogs provides a mock function with given fields: page, perPage // QueryLogs provides a mock function with given fields: rctx, page, perPage
func (_m *ClusterInterface) QueryLogs(page int, perPage int) (map[string][]string, *model.AppError) { func (_m *ClusterInterface) QueryLogs(rctx request.CTX, page int, perPage int) (map[string][]string, *model.AppError) {
ret := _m.Called(page, perPage) ret := _m.Called(rctx, page, perPage)
if len(ret) == 0 { if len(ret) == 0 {
panic("no return value specified for QueryLogs") panic("no return value specified for QueryLogs")
@@ -273,19 +273,19 @@ func (_m *ClusterInterface) QueryLogs(page int, perPage int) (map[string][]strin
var r0 map[string][]string var r0 map[string][]string
var r1 *model.AppError var r1 *model.AppError
if rf, ok := ret.Get(0).(func(int, int) (map[string][]string, *model.AppError)); ok { if rf, ok := ret.Get(0).(func(request.CTX, int, int) (map[string][]string, *model.AppError)); ok {
return rf(page, perPage) return rf(rctx, page, perPage)
} }
if rf, ok := ret.Get(0).(func(int, int) map[string][]string); ok { if rf, ok := ret.Get(0).(func(request.CTX, int, int) map[string][]string); ok {
r0 = rf(page, perPage) r0 = rf(rctx, page, perPage)
} else { } else {
if ret.Get(0) != nil { if ret.Get(0) != nil {
r0 = ret.Get(0).(map[string][]string) r0 = ret.Get(0).(map[string][]string)
} }
} }
if rf, ok := ret.Get(1).(func(int, int) *model.AppError); ok { if rf, ok := ret.Get(1).(func(request.CTX, int, int) *model.AppError); ok {
r1 = rf(page, perPage) r1 = rf(rctx, page, perPage)
} else { } else {
if ret.Get(1) != nil { if ret.Get(1) != nil {
r1 = ret.Get(1).(*model.AppError) r1 = ret.Get(1).(*model.AppError)