Revert "Add read_channel_content permission (#24018)" (#24114)

This reverts commit a19ce047ba.

server/channels/store/sqlstore/integrity_test.go

@@ -258,7 +258,6 @@ func createDefaultRoles(ss store.Store) {
 		DisplayName: model.ChannelUserRoleId,
 		Permissions: []string{
 			model.PermissionReadChannel.Id,
-			model.PermissionReadChannelContent.Id,
 			model.PermissionCreatePost.Id,
 		},
 	})
@@ -268,7 +267,6 @@ func createDefaultRoles(ss store.Store) {
 		DisplayName: model.ChannelGuestRoleId,
 		Permissions: []string{
 			model.PermissionReadChannel.Id,
-			model.PermissionReadChannelContent.Id,
 			model.PermissionCreatePost.Id,
 		},
 	})

server/channels/store/storetest/scheme_store.go

@@ -67,7 +67,6 @@ func createDefaultRoles(ss store.Store) {
 		DisplayName: model.ChannelUserRoleId,
 		Permissions: []string{
 			model.PermissionReadChannel.Id,
-			model.PermissionReadChannelContent.Id,
 			model.PermissionCreatePost.Id,
 		},
 	})
@@ -77,7 +76,6 @@ func createDefaultRoles(ss store.Store) {
 		DisplayName: model.ChannelGuestRoleId,
 		Permissions: []string{
 			model.PermissionReadChannel.Id,
-			model.PermissionReadChannelContent.Id,
 			model.PermissionCreatePost.Id,
 		},
 	})
@@ -160,7 +158,7 @@ func testSchemeStoreSave(t *testing.T, ss store.Store) {
 
 	role4, err := ss.Role().GetByName(context.Background(), d1.DefaultChannelUserRole)
 	assert.NoError(t, err)
-	assert.Equal(t, role4.Permissions, []string{"read_channel", "read_channel_content", "create_post"})
+	assert.Equal(t, role4.Permissions, []string{"read_channel", "create_post"})
 	assert.True(t, role4.SchemeManaged)
 
 	role5, err := ss.Role().GetByName(context.Background(), d1.DefaultTeamGuestRole)
@@ -170,7 +168,7 @@ func testSchemeStoreSave(t *testing.T, ss store.Store) {
 
 	role6, err := ss.Role().GetByName(context.Background(), d1.DefaultChannelGuestRole)
 	assert.NoError(t, err)
-	assert.Equal(t, role6.Permissions, []string{"read_channel", "read_channel_content", "create_post"})
+	assert.Equal(t, role6.Permissions, []string{"read_channel", "create_post"})
 	assert.True(t, role6.SchemeManaged)
 
 	// Change the scheme description and update.
@@ -388,7 +386,7 @@ func testSchemeStoreDelete(t *testing.T, ss store.Store) {
 
 	role4, err := ss.Role().GetByName(context.Background(), d1.DefaultChannelUserRole)
 	assert.NoError(t, err)
-	assert.Equal(t, role4.Permissions, []string{"read_channel", "read_channel_content", "create_post"})
+	assert.Equal(t, role4.Permissions, []string{"read_channel", "create_post"})
 	assert.True(t, role4.SchemeManaged)
 
 	role5, err := ss.Role().GetByName(context.Background(), d1.DefaultTeamGuestRole)
@@ -398,7 +396,7 @@ func testSchemeStoreDelete(t *testing.T, ss store.Store) {
 
 	role6, err := ss.Role().GetByName(context.Background(), d1.DefaultChannelGuestRole)
 	assert.NoError(t, err)
-	assert.Equal(t, role6.Permissions, []string{"read_channel", "read_channel_content", "create_post"})
+	assert.Equal(t, role6.Permissions, []string{"read_channel", "create_post"})
 	assert.True(t, role6.SchemeManaged)
 
 	// Delete the scheme.