Implement GET channels endpoints for APIv4 (#5363)
* implement get channels endpoints and updated drivers and unittests * removed channel deletion on tear down, removed manage permission on get channels endpoints, and updated utils to add constant channel length * added constants for user, team and channel length, updated context to use the model functions * make sure team name length should be less than the minimum length and revert underscore to team name validity * changed post test condition from notfound to unauthorized
Этот коммит содержится в:
коммит произвёл
Harrison Healey
родитель
9dabd10da9
Коммит
28aa7cdbf2
@@ -364,12 +364,8 @@ func (c *Context) RequireUsername() *Context {
|
||||
return c
|
||||
}
|
||||
|
||||
if len(c.Params.Username) < 3 {
|
||||
c.SetInvalidUrlParam("username")
|
||||
}
|
||||
|
||||
if len(c.Params.Username) > 22 {
|
||||
c.SetInvalidUrlParam("username")
|
||||
if !model.IsValidUsername(c.Params.Username) {
|
||||
c.SetInvalidParam("username")
|
||||
}
|
||||
|
||||
return c
|
||||
@@ -386,16 +382,40 @@ func (c *Context) RequirePostId() *Context {
|
||||
return c
|
||||
}
|
||||
|
||||
func (c *Context) RequireTeamName() *Context {
|
||||
if c.Err != nil {
|
||||
return c
|
||||
}
|
||||
|
||||
if !model.IsValidTeamName(c.Params.TeamName){
|
||||
c.SetInvalidUrlParam("team_name")
|
||||
}
|
||||
|
||||
return c
|
||||
}
|
||||
|
||||
func (c *Context) RequireChannelName() *Context {
|
||||
if c.Err != nil {
|
||||
return c
|
||||
}
|
||||
|
||||
if !model.IsValidChannelIdentifier(c.Params.ChannelName) {
|
||||
c.SetInvalidUrlParam("channel_name")
|
||||
}
|
||||
|
||||
return c
|
||||
}
|
||||
|
||||
func (c *Context) RequireEmail() *Context {
|
||||
if c.Err != nil {
|
||||
return c
|
||||
}
|
||||
|
||||
pos := strings.Index(c.Params.Email, "@")
|
||||
if pos < 0 {
|
||||
if !model.IsValidEmail(c.Params.Email) {
|
||||
c.SetInvalidUrlParam("email")
|
||||
}
|
||||
|
||||
return c
|
||||
}
|
||||
|
||||
|
||||
|
||||
Ссылка в новой задаче
Block a user