[MM-13033] Continue bulk import on large image error (#10780)
* [MM-13033] Continue bulk import on large image error * add tests, review comments * Update app/import_functions.go Co-Authored-By: liusy182 <liusy182@hotmail.com>
Этот коммит содержится в:
коммит произвёл
Jesús Espino
родитель
66cb36f5dc
Коммит
27566f6a06
@@ -909,7 +909,6 @@ func (a *App) ImportReply(data *ReplyImportData, post *model.Post, teamId string
|
||||
}
|
||||
|
||||
func (a *App) ImportAttachment(data *AttachmentImportData, post *model.Post, teamId string, dryRun bool) (*model.FileInfo, *model.AppError) {
|
||||
fileUploadError := model.NewAppError("BulkImport", "app.import.attachment.file_upload.error", map[string]interface{}{"FilePath": *data.Path}, "", http.StatusBadRequest)
|
||||
file, err := os.Open(*data.Path)
|
||||
if err != nil {
|
||||
return nil, model.NewAppError("BulkImport", "app.import.attachment.bad_file.error", map[string]interface{}{"FilePath": *data.Path}, "", http.StatusBadRequest)
|
||||
@@ -922,8 +921,8 @@ func (a *App) ImportAttachment(data *AttachmentImportData, post *model.Post, tea
|
||||
fileInfo, err := a.DoUploadFile(timestamp, teamId, post.ChannelId, post.UserId, file.Name(), buf.Bytes())
|
||||
|
||||
if err != nil {
|
||||
fmt.Print(err)
|
||||
return nil, fileUploadError
|
||||
mlog.Error(fmt.Sprintf("Failed to upload file: %s", err.Error()))
|
||||
return nil, err
|
||||
}
|
||||
|
||||
a.HandleImages([]string{fileInfo.PreviewPath}, []string{fileInfo.ThumbnailPath}, [][]byte{buf.Bytes()})
|
||||
@@ -931,7 +930,7 @@ func (a *App) ImportAttachment(data *AttachmentImportData, post *model.Post, tea
|
||||
mlog.Info(fmt.Sprintf("uploading file with name %s", file.Name()))
|
||||
return fileInfo, nil
|
||||
}
|
||||
return nil, fileUploadError
|
||||
return nil, model.NewAppError("BulkImport", "app.import.attachment.file_upload.error", map[string]interface{}{"FilePath": *data.Path}, "", http.StatusBadRequest)
|
||||
}
|
||||
|
||||
func (a *App) ImportPost(data *PostImportData, dryRun bool) *model.AppError {
|
||||
|
||||
Ссылка в новой задаче
Block a user