Remove insights (#23952)

* removed server side

* Updated store layer

* unused import

* Updated autogenerated code template

* Updated tests

* lint fix

* unused translations

* webapp side

* Updated i18n

* lint fix:

* type fix

* Updated snapshots

* Removed insights from API specs

* updated e2e

* Updated e2e tests

* Updated e2e tests

* Removed insights tests

* Removed Insights as possible channel to load in sidebar from test

* Removed more insights tests

* More e2e fixed

* More cleanup

* Lint

* More cleanup in client4 and boards api

* More cleanup

* Fixes

* lint fix

---------

Co-authored-by: maria.nunez <maria.nunez@mattermost.com>
Co-authored-by: Mattermost Build <build@mattermost.com>

server/config/client.go

@@ -134,7 +134,6 @@ func GenerateClientConfig(c *model.Config, telemetryID string, license *model.Li
 	props["ExperimentalSharedChannels"] = "false"
 	props["CollapsedThreads"] = *c.ServiceSettings.CollapsedThreads
 	props["EnableCustomGroups"] = "false"
-	props["InsightsEnabled"] = strconv.FormatBool(c.FeatureFlags.InsightsEnabled)
 	props["PostPriority"] = strconv.FormatBool(*c.ServiceSettings.PostPriority)
 	props["AllowPersistentNotifications"] = strconv.FormatBool(*c.ServiceSettings.AllowPersistentNotifications)
 	props["AllowPersistentNotificationsForGuests"] = strconv.FormatBool(*c.ServiceSettings.AllowPersistentNotificationsForGuests)

server/config/client_test.go

@@ -150,70 +150,6 @@ func TestGetClientConfig(t *testing.T) {
 				"ShowFullName": "true",
 			},
 		},
-		{
-			"Insights professional license",
-			&model.Config{
-				FeatureFlags: &model.FeatureFlags{
-					InsightsEnabled: true,
-				},
-			},
-			"",
-			&model.License{
-				Features:     &model.Features{},
-				SkuShortName: model.LicenseShortSkuProfessional,
-			},
-			map[string]string{
-				"InsightsEnabled": "true",
-			},
-		},
-		{
-			"Insights enterprise license",
-			&model.Config{
-				FeatureFlags: &model.FeatureFlags{
-					InsightsEnabled: true,
-				},
-			},
-			"",
-			&model.License{
-				Features:     &model.Features{},
-				SkuShortName: model.LicenseShortSkuEnterprise,
-			},
-			map[string]string{
-				"InsightsEnabled": "true",
-			},
-		},
-		{
-			"Insights other license",
-			&model.Config{
-				FeatureFlags: &model.FeatureFlags{
-					InsightsEnabled: true,
-				},
-			},
-			"",
-			&model.License{
-				Features:     &model.Features{},
-				SkuShortName: "other",
-			},
-			map[string]string{
-				"InsightsEnabled": "true",
-			},
-		},
-		{
-			"Insights professional license, feature flag disabled",
-			&model.Config{
-				FeatureFlags: &model.FeatureFlags{
-					InsightsEnabled: false,
-				},
-			},
-			"",
-			&model.License{
-				Features:     &model.Features{},
-				SkuShortName: model.LicenseShortSkuProfessional,
-			},
-			map[string]string{
-				"InsightsEnabled": "false",
-			},
-		},
 		{
 			"Custom groups professional license",
 			&model.Config{},
@@ -240,11 +176,7 @@ func TestGetClientConfig(t *testing.T) {
 		},
 		{
 			"Custom groups other license",
-			&model.Config{
-				FeatureFlags: &model.FeatureFlags{
-					InsightsEnabled: true,
-				},
-			},
+			&model.Config{},
 			"",
 			&model.License{
 				Features:     &model.Features{},