PLT-7622 Improvements to server handling of webapp plugins (#7445)

* Improvements to server handling of webapp plugins

* Fix newline

* Update manifest function names

plugin/pluginenv/environment.go

@@ -66,7 +66,7 @@ func (env *Environment) Plugins() ([]*model.BundleInfo, error) {
 }
 
 // Returns a list of all currently active plugins within the environment.
-func (env *Environment) ActivePlugins() ([]*model.BundleInfo, error) {
+func (env *Environment) ActivePlugins() []*model.BundleInfo {
 	env.mutex.RLock()
 	defer env.mutex.RUnlock()
 
@@ -75,7 +75,7 @@ func (env *Environment) ActivePlugins() ([]*model.BundleInfo, error) {
 		activePlugins = append(activePlugins, p.BundleInfo)
 	}
 
-	return activePlugins, nil
+	return activePlugins
 }
 
 // Returns the ids of the currently active plugins.

plugin/pluginenv/environment_test.go

@@ -127,8 +127,7 @@ func TestEnvironment(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Len(t, plugins, 3)
 
-	activePlugins, err := env.ActivePlugins()
-	assert.NoError(t, err)
+	activePlugins := env.ActivePlugins()
 	assert.Len(t, activePlugins, 0)
 
 	assert.Error(t, env.ActivatePlugin("x"))
@@ -150,8 +149,7 @@ func TestEnvironment(t *testing.T) {
 
 	assert.NoError(t, env.ActivatePlugin("foo"))
 	assert.Equal(t, env.ActivePluginIds(), []string{"foo"})
-	activePlugins, err = env.ActivePlugins()
-	assert.NoError(t, err)
+	activePlugins = env.ActivePlugins()
 	assert.Len(t, activePlugins, 1)
 	assert.Error(t, env.ActivatePlugin("foo"))