diff --git a/store/sqlstore/status_store.go b/store/sqlstore/status_store.go index 2b6bed4c72..b5ce130c75 100644 --- a/store/sqlstore/status_store.go +++ b/store/sqlstore/status_store.go @@ -11,7 +11,6 @@ import ( sq "github.com/Masterminds/squirrel" "github.com/pkg/errors" - "github.com/mattermost/gorp" "github.com/mattermost/mattermost-server/v6/model" "github.com/mattermost/mattermost-server/v6/store" ) @@ -57,7 +56,7 @@ func (s SqlStatusStore) SaveOrUpdate(st *model.Status) error { return errors.Wrap(err, "status_tosql") } - if _, err := s.GetMaster().Exec(queryString, args...); err != nil { + if _, err := s.GetMasterX().Exec(queryString, args...); err != nil { return errors.Wrap(err, "failed to upsert Status") } @@ -67,13 +66,7 @@ func (s SqlStatusStore) SaveOrUpdate(st *model.Status) error { func (s SqlStatusStore) Get(userId string) (*model.Status, error) { var status model.Status - if err := s.GetReplica().SelectOne(&status, - `SELECT - * - FROM - Status - WHERE - UserId = :UserId`, map[string]interface{}{"UserId": userId}); err != nil { + if err := s.GetReplicaX().Get(&status, "SELECT * FROM Status WHERE UserId = ?", userId); err != nil { if err == sql.ErrNoRows { return nil, store.NewErrNotFound("Status", fmt.Sprintf("userId=%s", userId)) } @@ -91,11 +84,11 @@ func (s SqlStatusStore) GetByIds(userIds []string) ([]*model.Status, error) { if err != nil { return nil, errors.Wrap(err, "status_tosql") } - rows, err := s.GetReplica().Db.Query(queryString, args...) + rows, err := s.GetReplicaX().DB.Query(queryString, args...) if err != nil { return nil, errors.Wrap(err, "failed to find Statuses") } - var statuses []*model.Status + statuses := []*model.Status{} defer rows.Close() for rows.Next() { var status model.Status @@ -112,8 +105,8 @@ func (s SqlStatusStore) GetByIds(userIds []string) ([]*model.Status, error) { } // MySQL doesn't have support for RETURNING clause, so we use a transaction to get the updated rows. -func (s SqlStatusStore) updateExpiredStatuses(t *gorp.Transaction) ([]*model.Status, error) { - var statuses []*model.Status +func (s SqlStatusStore) updateExpiredStatuses(t *sqlxTxWrapper) ([]*model.Status, error) { + statuses := []*model.Status{} currUnixTime := time.Now().UTC().Unix() selectQuery, selectParams, err := s.getQueryBuilder(). Select("*"). @@ -128,7 +121,7 @@ func (s SqlStatusStore) updateExpiredStatuses(t *gorp.Transaction) ([]*model.Sta if err != nil { return nil, errors.Wrap(err, "status_tosql") } - _, err = t.Select(&statuses, selectQuery, selectParams...) + err = t.Select(&statuses, selectQuery, selectParams...) if err != nil { return nil, errors.Wrap(err, "updateExpiredStatusesT: failed to get expired dnd statuses") } @@ -160,11 +153,11 @@ func (s SqlStatusStore) updateExpiredStatuses(t *gorp.Transaction) ([]*model.Sta func (s SqlStatusStore) UpdateExpiredDNDStatuses() ([]*model.Status, error) { if s.DriverName() == model.DatabaseDriverMysql { - transaction, err := s.GetMaster().Begin() + transaction, err := s.GetMasterX().Beginx() if err != nil { return nil, errors.Wrap(err, "UpdateExpiredDNDStatuses: begin_transaction") } - defer finalizeTransaction(transaction) + defer finalizeTransactionX(transaction) statuses, err := s.updateExpiredStatuses(transaction) if err != nil { return nil, errors.Wrap(err, "UpdateExpiredDNDStatuses: updateExpiredDNDStatusesT") @@ -203,12 +196,12 @@ func (s SqlStatusStore) UpdateExpiredDNDStatuses() ([]*model.Status, error) { return nil, errors.Wrap(err, "status_tosql") } - rows, err := s.GetMaster().Query(queryString, args...) + rows, err := s.GetMasterX().Query(queryString, args...) if err != nil { return nil, errors.Wrap(err, "failed to find Statuses") } defer rows.Close() - var statuses []*model.Status + statuses := []*model.Status{} for rows.Next() { var status model.Status if err = rows.Scan(&status.UserId, &status.Status, &status.Manual, &status.LastActivityAt, @@ -225,7 +218,7 @@ func (s SqlStatusStore) UpdateExpiredDNDStatuses() ([]*model.Status, error) { } func (s SqlStatusStore) ResetAll() error { - if _, err := s.GetMaster().Exec("UPDATE Status SET Status = :Status WHERE Manual = false", map[string]interface{}{"Status": model.StatusOffline}); err != nil { + if _, err := s.GetMasterX().Exec("UPDATE Status SET Status = ? WHERE Manual = false", model.StatusOffline); err != nil { return errors.Wrap(err, "failed to update Statuses") } return nil @@ -233,7 +226,8 @@ func (s SqlStatusStore) ResetAll() error { func (s SqlStatusStore) GetTotalActiveUsersCount() (int64, error) { time := model.GetMillis() - (1000 * 60 * 60 * 24) - count, err := s.GetReplica().SelectInt("SELECT COUNT(UserId) FROM Status WHERE LastActivityAt > :Time", map[string]interface{}{"Time": time}) + var count int64 + err := s.GetReplicaX().Get(&count, "SELECT COUNT(UserId) FROM Status WHERE LastActivityAt > ?", time) if err != nil { return count, errors.Wrap(err, "failed to count active users") } @@ -241,7 +235,7 @@ func (s SqlStatusStore) GetTotalActiveUsersCount() (int64, error) { } func (s SqlStatusStore) UpdateLastActivityAt(userId string, lastActivityAt int64) error { - if _, err := s.GetMaster().Exec("UPDATE Status SET LastActivityAt = :Time WHERE UserId = :UserId", map[string]interface{}{"UserId": userId, "Time": lastActivityAt}); err != nil { + if _, err := s.GetMasterX().Exec("UPDATE Status SET LastActivityAt = ? WHERE UserId = ?", lastActivityAt, userId); err != nil { return errors.Wrapf(err, "failed to update last activity for userId=%s", userId) }