mirrors/mostlymatter
1
0
Форкнуть 0
Код Задачи Запросы на слияние Действия Пакеты Проекты Релизы Вики Активность

[MM-62384] Move ChannelHeaderPopover from BootstrapOverlay/Popper to Floating-UI (#29820)

Просмотр исходного кода
Этот коммит содержится в:
M-ZubairAhmed
2025-01-14 17:19:55 +05:30
коммит произвёл GitHub
родитель 7cf040655f
Коммит 25a6501e10
20 изменённых файлов: 1264 добавлений и 1980 удалений
Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

6
e2e-tests/cypress/tests/integration/channels/messaging/direct_message_spec.js
Просмотреть файл

@@ -150,12 +150,12 @@ describe('Direct Message', () => {
cy.get('#edit_textbox').type(message).type('{enter}').wait(TIMEOUTS.HALF_SEC);
// # Hover on channel header
cy.get('#channelHeaderDescription .header-description__text').trigger('mouseover');
cy.get('#channelHeaderDescription .header-description__text').trigger('mouseenter');
// * Verify changes have been applied on header
cy.wait(TIMEOUTS.HALF_SEC);
cy.get('#header-popover .popover-content').should('be.visible');
cy.get('#header-popover').find('.popover-content').should(($el) => {
cy.get('.channel-header-text-popover').should('be.visible');
cy.get('.channel-header-text-popover').should(($el) => {
expect($el.get(0).innerText).to.eq(expectedMessage);
});
});

17
e2e-tests/cypress/tests/integration/channels/messaging/header_spec.js
Просмотреть файл

@@ -58,12 +58,13 @@ describe('Header', () => {
updateAndVerifyChannelHeader('>', header);
// # Click the header to see the whole text
cy.get('#channelHeaderDescription').click();
// # Hover on channel header
cy.get('#channelHeaderDescription .header-description__text').trigger('mouseenter');
// * Check that no ellipsis is present
cy.get('#header-popover > div.popover-content').
should('have.html', `<span><blockquote>\n<p>${header}</p>\n</blockquote></span>`);
cy.get('.channel-header-text-popover').should(($el) => {
expect($el.get(0).innerText).to.eq(header);
});
cy.apiSaveMessageDisplayPreference('clean');
});
@@ -75,12 +76,14 @@ function updateAndVerifyChannelHeader(prefix, header) {
// * Should render blockquote if it starts with ">"
if (prefix === '>') {
cy.get('#channelHeaderDescription > span > blockquote').should('be.visible');
cy.get('.header-description__text').within(() => {
cy.get('blockquote').should('be.visible');
});
}
// * Check if channel header description has ellipsis
cy.get('#channelHeaderDescription > .header-description__text').find('p').
should('have.text', header).
cy.get('.header-description__text').
should('include.text', header).
and('have.css', 'overflow', 'hidden').
and('have.css', 'text-overflow', 'ellipsis');
}

92
e2e-tests/cypress/tests/integration/channels/multi_team_and_dm/gm_header_spec.js
Просмотреть файл

@@ -47,28 +47,36 @@ describe('Multi-user group header', () => {
cy.apiLogin(testUser);
cy.visit(`/${testTeam.name}/channels/${groupChannel.name}`);
// * no channel header is set
cy.get('button.header-placeholder').invoke('show').trigger('mouseover');
cy.contains('#channelHeaderDescription button span', 'Add a channel header').should('be.visible');
const header = 'peace and progress';
// # click add a channel heander
cy.findByRoleExtended('button', {name: 'Add a channel header'}).should('be.visible').click();
// * Verify that no channel header is set
cy.get('#channel-header').within(() => {
cy.findByText('Add a channel header').should('not.be.visible');
});
// # type a header
const header = 'this is a header!';
// # Force click on button which is hidden and shows on hover
cy.findByText('Add a channel header').click({force: true});
// * Verify the modal open to add header
cy.get('#editChannelHeaderModalLabel').should('be.visible').wait(TIMEOUTS.ONE_SEC);
cy.get('textarea#edit_textbox').should('be.visible').type(`${header}{enter}`);
cy.get('#editChannelHeaderModalLabel').should('not.exist'); // wait for modal to disappear
// # Add the header in the modal
cy.findByPlaceholderText('Edit the Channel Header...').should('be.visible').type(`${header}{enter}`);
// # Wait for modal to disappear
cy.waitUntil(() => cy.get('#editChannelHeaderModalLabel').should('not.be.visible'));
// * text appears in the top center panel
cy.contains('#channelHeaderDescription span.header-description__text p', header);
cy.get('#channel-header').within(() => {
cy.findByText(header).should('be.visible');
});
checkSystemMessage('updated the channel header');
// * channel is marked as read for the current user
// * Channel is marked as read for the current user
cy.get(`#sidebarItem_${groupChannel.name}`).should(beRead);
// * channel is marked as unread for other user
// * Channel is marked as unread for other user
cy.apiLogout();
cy.apiLogin(userList[0]);
cy.visit(`/${testTeam.name}/channels/town-square`);
@@ -81,18 +89,22 @@ describe('Multi-user group header', () => {
cy.apiLogin(testUser);
cy.visit(`/${testTeam.name}/channels/${groupChannel.name}`);
// * verify header is set
cy.contains('#channelHeaderDescription button span', 'Add a channel header').should('not.exist');
// * Verify that channel header is set
cy.get('#channel-header').within(() => {
cy.findByText('Add a channel header').should('not.exist');
});
const header = 'this is a new header!';
const header = 'In pursuit of peace and progress';
editHeader(header);
// * text appears at the top
cy.contains('#channelHeaderDescription span.header-description__text p', header);
// * Header text appears at the top
cy.get('#channel-header').within(() => {
cy.findByText(header).should('be.visible');
});
checkSystemMessage('updated the channel header');
// * channel is marked as unread for other users
// * Channel is marked as unread for other users
cy.apiLogout();
cy.apiLogin(userList[0]);
cy.visit(`/${testTeam.name}/channels/town-square`);
@@ -101,35 +113,43 @@ describe('Multi-user group header', () => {
});
it('MM-T473_2 Edit GM channel header', () => {
// # open existing GM
// # Open existing GM
cy.apiLogin(testUser);
cy.visit(`/${testTeam.name}/channels/${groupChannel.name}`);
// * verify header is set
cy.contains('#channelHeaderDescription button span', 'Add a channel header').should('not.exist');
// * Verify that channel header is set
cy.get('#channel-header').within(() => {
cy.findByText('Add a channel header').should('not.exist');
});
const header = `Header by @${testUser.username}`;
const header = `In pursuit of peace and progress by @${testUser.username}`;
editHeader(header);
cy.get('#channelHeaderDescription').find('.header-description__text').
find('.mention-link').
should('be.visible').and('have.text', `@${testUser.username}`);
cy.get('#channelHeaderDescription').find('.header-description__text').
find('.mention--highlight').
should('not.exist');
// * Header text appears at the top
cy.get('#channel-header').within(() => {
// * Verify mention is present
cy.get('.mention-link').should('be.visible').and('have.text', `@${testUser.username}`);
// * Verify its not highlighted
cy.get('.mention--highlight').should('not.exist');
});
});
const editHeader = (header) => {
function editHeader(header) {
// # Click edit conversation header
cy.uiOpenChannelMenu('Edit Conversation Header');
// # type new header
cy.get('#editChannelHeaderModalLabel').should('be.visible');
cy.get('textarea#edit_textbox').should('be.visible').clear().type(`${header}{enter}`);
cy.get('#editChannelHeaderModalLabel').should('not.exist'); // wait for modal to disappear
};
// * Verify the modal open to add header
cy.get('#editChannelHeaderModalLabel').should('be.visible').wait(TIMEOUTS.ONE_SEC);
const checkSystemMessage = (message) => {
// # Add the header in the modal
cy.get('textarea#edit_textbox').should('be.visible').clear().type(`${header}{enter}`);
// # Wait for modal to disappear
cy.waitUntil(() => cy.get('#editChannelHeaderModalLabel').should('not.be.visible'));
}
function checkSystemMessage(message) {
// * system message is posted notifying of the change
cy.getLastPostId().then((id) => {
cy.get(`#postMessageText_${id}`).should('contain', message);
@@ -138,5 +158,5 @@ describe('Multi-user group header', () => {
cy.get(`#delete_post_${id}`);
});
});
};
}
});